Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing findAll with CSS selector to SelenideDriver #1145

Merged
merged 1 commit into from
May 14, 2020
Merged

Add missing findAll with CSS selector to SelenideDriver #1145

merged 1 commit into from
May 14, 2020

Conversation

jreznot
Copy link
Contributor

@jreznot jreznot commented May 10, 2020

Proposed changes

Here we add findAll(String cssSelector) to SelenideDriver so now it is possible to use it like short find(String). Mostly required for Kotlin tests. For some reason it was missing in SelenideDriver while it already has find(String).

Checklist

  • Checkstyle and unit tests are passed locally with my changes by running gradlew check chrome_headless firefox_headless command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@asolntsev asolntsev self-assigned this May 14, 2020
@asolntsev asolntsev added this to the 5.12.0 milestone May 14, 2020
@asolntsev asolntsev merged commit 07c7b61 into selenide:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants