split the single gradle project to subprojects #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
force-pushed
the
subprojects
branch
from
f482957
to
24f01d8
Compare
rosolko
approved these changes
Dec 10, 2020
| @@ -1,3 +1,7 @@ | |||
| org.gradle.parallel=true | |||
| org.gradle.configureondemand=true | |||
| org.gradle.jvmargs=-Xmx256m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8 | |||
|
|
|||
There was a problem hiding this comment.
If you're added org.gradle.caching=true can you please also add org.gradle.vfs.watch=true configuration?
| task libsTest(type: Sync) { | ||
| from configurations.testRuntimeClasspath - configurations.compileClasspath | ||
| into "$buildDir/lib-test" | ||
| subprojects { |
There was a problem hiding this comment.
Maybe we can use or just think about it - composite builds
There was a problem hiding this comment.
yes, I will try composite builds.
rosolko
reviewed
Dec 10, 2020
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
asolntsev
force-pushed
the
subprojects
branch
2 times, most recently
from
ba87c76
to
0ee45ca
Compare
asolntsev
force-pushed
the
subprojects
branch
from
abdb3ef
to
e0574d9
Compare
+ extract `junit4` subproject + extract `testng` subproject + extract `grid` subproject
asolntsev
force-pushed
the
subprojects
branch
from
e0574d9
to
c40edbe
Compare
asolntsev
force-pushed
the
subprojects
branch
from
c40edbe
to
1aa3bf0
Compare
for some reason, File.exists() != File.getAbsoluteFile().exists() ...
asolntsev
force-pushed
the
subprojects
branch
from
557864c
to
d01d765
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
junit4subprojecttestngsubprojectgridsubprojectProposed changes
extract JUnit4-related code to
modules/junit4and TestNG-related code tomodules/testng.The goal is to avoid mixing junit.jar and testng.jar in common classpath. For example, AssertJ
assumeThatworks incorrectly if encounters both jars in classpath.