#1850 don't include Mockito & AssertJ in all modules #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we have at least two module (junit4) without both Mockito and AssertJ dependencies. This will verify that Selenide works without them (at least Selenium listeners need byte-buddy). The case #1850 was that we removed byte-buddy dependency, and Selenide didn't work without it. But our tests didn't show the problem because we occasionally fetched transitive byte-buddy dependency from Mockito or AssertJ.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to guarantee #1850 will never happen again.
Now we have at least two module (junit4) without both Mockito and AssertJ dependencies. This will verify that Selenide works without them (at least Selenium listeners need byte-buddy).
The case #1850 was that we removed byte-buddy dependency, and Selenide didn't work without it. But our tests didn't show the problem because we occasionally fetched transitive byte-buddy dependency from Mockito or AssertJ.