#2617 User can safely add the same proxy filter many times #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's convenient to store a filter into a constant, and add it before every `open(url)` - without checking if it was already added earlier.
```
var MY_CONSTANT_LOGGER = new RequestFilter() {...}
getSelenideProxy().addRequestFilter("request-logger", MY_CONSTANT_LOGGER);
```
|
rosolko
approved these changes
Jan 29, 2024
rosolko
reviewed
Jan 29, 2024
| @@ -116,15 +116,14 @@ public boolean isStarted() { | |||
| * @param requestFilter the filter | |||
| */ | |||
| public void addRequestFilter(String name, RequestFilter requestFilter) { | |||
| if (isRequestFilterAdded(name)) { | |||
| RequestFilter currentFilter = requestFilter(name); | |||
| if (currentFilter != null && !currentFilter.equals(requestFilter)) { | |||
There was a problem hiding this comment.
Maybe better to use such verification and skip next currentFilter null check as well?
Suggested change
| if (currentFilter != null && !currentFilter.equals(requestFilter)) { | |
| if (Objects.equals(currentFilter, requestFilter)) { |
There was a problem hiding this comment.
@rosolko Nice try, but no :)
Then this method will throw exception if currentFilter == null. But should not.
| @@ -134,11 +133,14 @@ private boolean isRequestFilterAdded(String name) { | |||
| * @param responseFilter the filter | |||
| */ | |||
| public void addResponseFilter(String name, ResponseFilter responseFilter) { | |||
| if (responseFilters.containsKey(name)) { | |||
| ResponseFilter currentFilter = responseFilter(name); | |||
| if (currentFilter != null && !currentFilter.equals(responseFilter)) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's convenient to store a filter into a constant, and add it before every
open(url)- without checking if it was already added earlier.