#2635 Add ability to perform click at disabled elements #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
force-pushed
the
feature/2635-click-disabled-elements
branch
from
c9a6d05
to
60d7e69
Compare
BorisOsipov
reviewed
Feb 3, 2024
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
| * #2550 Implement downloading files via CDP or BiDi (#2567) - thanks to Sergey Brit! | |||
| * #2612 don't set page load timeout in mobile tests (#2628) | |||
| * #2617 User can safely add the same proxy filter many times (#2630) | |||
| * #2635 Add ability to perform click at disabled elements (#2636) | |||
There was a problem hiding this comment.
Suggested change
| * #2635 Add ability to perform click at disabled elements (#2636) | |
| * #2635 Add the ability to skip checks before clicking an element (#2636) |
BorisOsipov
reviewed
Feb 3, 2024
| */ | ||
| @CheckReturnValue | ||
| @Nonnull | ||
| public ClickOptions allowDisabled() { |
There was a problem hiding this comment.
Suggested change
| public ClickOptions allowDisabled() { | |
| public ClickOptions force() { |
BorisOsipov
reviewed
Feb 3, 2024
| @Test | ||
| void clickingDisabledButtonMayBeAllowed() { | ||
| assertThatNoException().isThrownBy(() -> | ||
| $("#submit").click(usingDefaultMethod().allowDisabled()) |
There was a problem hiding this comment.
Suggested change
| $("#submit").click(usingDefaultMethod().allowDisabled()) | |
| $("#submit").click(usingDefaultMethod().force()) |
BorisOsipov
reviewed
Feb 3, 2024
| @Test | ||
| void doubleClickingDisabledButtonMayBeAllowed() { | ||
| assertThatNoException().isThrownBy(() -> | ||
| $("#submit").doubleClick(usingDefaultMethod().allowDisabled()) |
There was a problem hiding this comment.
Suggested change
| $("#submit").doubleClick(usingDefaultMethod().allowDisabled()) | |
| $("#submit").doubleClick(usingDefaultMethod().force()) |
BorisOsipov
approved these changes
Feb 3, 2024
rosolko
approved these changes
Feb 3, 2024
NB! It's important to call `e.click()`, not `actions.moveToElement(e, 0, 0).click().perform()` because the latter doesn't check that the element is covered by other element, and doesn't throw "element is not clickable at point. Other element would receive the click" error.
... to avoid the risk that the following click misses the element because it's still moving
asolntsev
force-pushed
the
feature/2635-click-disabled-elements
branch
from
89f56a4
to
a07a9fb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we added parameter
forceto click: