#695 Do not open a browser if Configuration.reopenBrowserOnFail is …

[asolntsev]

…false and user has not set webdriver manually

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

• Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[BorisOsipov]

@asolntsev Do you take into account such changes will break tests for users who accidentally still use reopenBrowserOnFail=true?

[asolntsev]

@BorisOsipov Why? reopenBrowserOnFail is true by default. Nothing will change in this case.

[BorisOsipov]

@asolntsev I've misprinted. If someone accidentally or by some reason have been setted reopenBrowserOnFail=false.

[asolntsev]

@BorisOsipov Yes, right, in this case the behaviour will change. The browser will not start. It's ok for me. The test will fail with a clear error message:

java.lang.IllegalStateException: No webdriver is bound to current thread: 1, and cannot create a new webdriver because Configuration.reopenBrowserOnFail=false