New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#695 Do not open a browser if `Configuration.reopenBrowserOnFail` is … #754

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
2 participants
@asolntsev
Contributor

asolntsev commented Jun 5, 2018

false and user has not set webdriver manually

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Checklist

  • Checkstyle and unit tests pass locally with my changes by running gradle check chrome htmlunit command
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
#695 Do not open a browser if `Configuration.reopenBrowserOnFail` is …
…`false` and user has not set webdriver manually

@asolntsev asolntsev self-assigned this Jun 5, 2018

@asolntsev asolntsev requested a review from BorisOsipov Jun 5, 2018

@asolntsev asolntsev modified the milestones: 4.12.1, 4.12.2 Jun 5, 2018

@BorisOsipov

This comment has been minimized.

Member

BorisOsipov commented Jun 5, 2018

@asolntsev Do you take into account such changes will break tests for users who accidentally still use reopenBrowserOnFail=true?

@asolntsev

This comment has been minimized.

Contributor

asolntsev commented Jun 5, 2018

@BorisOsipov Why? reopenBrowserOnFail is true by default. Nothing will change in this case.

@BorisOsipov

This comment has been minimized.

Member

BorisOsipov commented Jun 5, 2018

@asolntsev I've misprinted. If someone accidentally or by some reason have been setted reopenBrowserOnFail=false.

@asolntsev

This comment has been minimized.

Contributor

asolntsev commented Jun 21, 2018

@BorisOsipov Yes, right, in this case the behaviour will change. The browser will not start. It's ok for me. The test will fail with a clear error message:

java.lang.IllegalStateException: No webdriver is bound to current thread: 1, and cannot create a new webdriver because Configuration.reopenBrowserOnFail=false

@asolntsev asolntsev merged commit d5dc87a into master Jun 21, 2018

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@asolntsev asolntsev deleted the do-not-open-browser branch Jun 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment