#928 Continue working if one of listeners threw an exception #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also allure-framework/allure-java#380 |
asolntsev
changed the title
rosolko
approved these changes
Jul 26, 2019
| @@ -98,8 +112,8 @@ public static void removeAllListeners() { | |||
| * If listener with given name is bound (added) to the current thread. | |||
| * | |||
| * @param name unique name of listener added by method {@link #addListener(String, LogEventListener)} | |||
| * @return true iff method {@link #addListener(String, LogEventListener)} with | |||
| * corresponding name has been called in current thread. | |||
| * @return true iff method {@link #addListener(String, LogEventListener)} with | |||
There was a problem hiding this comment.
Suggested change
| * @return true iff method {@link #addListener(String, LogEventListener)} with | |
| * @return true if method {@link #addListener(String, LogEventListener)} with |
Method `WebElement.isSelected()` may throw `WebDriverException` on iOS
asolntsev
force-pushed
the
fix-logging-if-listener-fails
branch
from
246d523
to
282e921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Checklist
gradle check chrome htmlunitcommand