Do some refactoring

seleniumbase · Dec 19, 2023 · c4b1408 · c4b1408
1 parent 0bb6ed6
commit c4b1408
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/seleniumbase/fixtures/base_case.py b/seleniumbase/fixtures/base_case.py
@@ -251,7 +251,15 @@ def open(self, url):
         try:
             self.driver.get(url)
         except Exception as e:
-            if (
+            if not hasattr(e, "msg") and hasattr(self.driver, "default_get"):
+                try:
+                    self._check_browser()
+                    time.sleep(0.4)
+                except Exception:
+                    logging.debug("Browser crashed! Will open new browser!")
+                    self.driver = self.get_new_driver()
+                self.driver.default_get(url)
+            elif (
                 "ERR_CONNECTION_TIMED_OUT" in e.msg
                 or "ERR_CONNECTION_CLOSED" in e.msg
                 or "ERR_CONNECTION_RESET" in e.msg
@@ -1018,7 +1026,7 @@ def add_text(self, selector, text, by="css selector", timeout=None):
             # Use after "\t" or Keys.TAB to cycle through elements first.
             self.click_active_element()
             return
-        element = self.wait_for_element_visible(
+        element = self.wait_for_element_present(
             selector, by=by, timeout=timeout
         )
         if (
@@ -1113,7 +1121,7 @@ def send_keys(self, selector, text, by="css selector", timeout=None):
     def press_keys(self, selector, text, by="css selector", timeout=None):
         """Use send_keys() to press one key at a time."""
         self.wait_for_ready_state_complete()
-        element = self.wait_for_element_clickable(
+        element = self.wait_for_element_present(
             selector, by=by, timeout=timeout
         )
         if self.demo_mode:

diff --git a/seleniumbase/fixtures/page_actions.py b/seleniumbase/fixtures/page_actions.py
@@ -1583,7 +1583,7 @@ def send_keys(
     driver, selector, text, by="css selector", timeout=settings.LARGE_TIMEOUT
 ):
     selector, by = page_utils.recalculate_selector(selector, by)
-    element = wait_for_element_clickable(
+    element = wait_for_element_present(
         driver, selector, by=by, timeout=timeout
     )
     if not text.endswith("\n"):
@@ -1597,7 +1597,7 @@ def press_keys(
     driver, selector, text, by="css selector", timeout=settings.LARGE_TIMEOUT
 ):
     selector, by = page_utils.recalculate_selector(selector, by)
-    element = wait_for_element_clickable(
+    element = wait_for_element_present(
         driver, selector, by=by, timeout=timeout
     )
     if not text.endswith("\n"):