Ensure all capabilities are either within desiredCapabilities or requ…

…iredCapabilities
SeleniumHQ · May 18, 2016 · a63d5e7 · a63d5e7
1 parent 98edbe8
commit a63d5e7
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/py/selenium/webdriver/remote/webdriver.py b/py/selenium/webdriver/remote/webdriver.py
@@ -167,11 +167,15 @@ def start_session(self, desired_capabilities, browser_profile=None):
          - javascript_enabled - Whether the new session should support JavaScript.
          - browser_profile - A selenium.webdriver.firefox.firefox_profile.FirefoxProfile object. Only used if Firefox is requested.
         """
+        capabilities = {}
+        for k, v in desired_capabilities.items():
+            if k not in ('desiredCapabilities', 'requiredCapabilities'):
+                capabilities.setdefault('desiredCapabilities', {})[k] = v
+            else:
+                capabilities[k] = v
         if browser_profile:
-            desired_capabilities['firefox_profile'] = browser_profile.encoded
-        response = self.execute(Command.NEW_SESSION, {
-            'desiredCapabilities': desired_capabilities,
-        })
+            capabilities['requiredCapabilities']['firefox_profile'] = browser_profile.encoded
+        response = self.execute(Command.NEW_SESSION, capabilities)
         self.session_id = response['sessionId']
         self.capabilities = response['value']