[rb] remove deprecated setter and getter methods for driver path in b…

…rowser modules
SeleniumHQ · Jun 23, 2022 · c9fe492 · c9fe492
1 parent 2a98236
commit c9fe492
Show file tree

Hide file tree

Showing 8 changed files with 0 additions and 120 deletions.
diff --git a/rb/lib/selenium/webdriver/chrome.rb b/rb/lib/selenium/webdriver/chrome.rb
@@ -28,20 +28,6 @@ module Chrome
       autoload :Options, 'selenium/webdriver/chrome/options'
       autoload :Service, 'selenium/webdriver/chrome/service'
 
-      def self.driver_path=(path)
-        WebDriver.logger.deprecate 'Selenium::WebDriver::Chrome#driver_path=',
-                                   'Selenium::WebDriver::Chrome::Service#driver_path=',
-                                   id: :driver_path
-        Selenium::WebDriver::Chrome::Service.driver_path = path
-      end
-
-      def self.driver_path
-        WebDriver.logger.deprecate 'Selenium::WebDriver::Chrome#driver_path',
-                                   'Selenium::WebDriver::Chrome::Service#driver_path',
-                                   id: :driver_path
-        Selenium::WebDriver::Chrome::Service.driver_path
-      end
-
       def self.path=(path)
         Platform.assert_executable path
         @path = path

diff --git a/rb/lib/selenium/webdriver/firefox.rb b/rb/lib/selenium/webdriver/firefox.rb
@@ -42,20 +42,6 @@ module Firefox
       # until WebDriver Bidi is available.
       DEVTOOLS_VERSION = 85
 
-      def self.driver_path=(path)
-        WebDriver.logger.deprecate 'Selenium::WebDriver::Firefox#driver_path=',
-                                   'Selenium::WebDriver::Firefox::Service#driver_path=',
-                                   id: :driver_path
-        Selenium::WebDriver::Firefox::Service.driver_path = path
-      end
-
-      def self.driver_path
-        WebDriver.logger.deprecate 'Selenium::WebDriver::Firefox#driver_path',
-                                   'Selenium::WebDriver::Firefox::Service#driver_path',
-                                   id: :driver_path
-        Selenium::WebDriver::Firefox::Service.driver_path
-      end
-
       def self.path=(path)
         Platform.assert_executable path
         @path = path

diff --git a/rb/lib/selenium/webdriver/ie.rb b/rb/lib/selenium/webdriver/ie.rb
@@ -23,20 +23,6 @@ module IE
       autoload :Driver, 'selenium/webdriver/ie/driver'
       autoload :Options, 'selenium/webdriver/ie/options'
       autoload :Service, 'selenium/webdriver/ie/service'
-
-      def self.driver_path=(path)
-        WebDriver.logger.deprecate 'Selenium::WebDriver::IE#driver_path=',
-                                   'Selenium::WebDriver::IE::Service#driver_path=',
-                                   id: :driver_path
-        Selenium::WebDriver::IE::Service.driver_path = path
-      end
-
-      def self.driver_path
-        WebDriver.logger.deprecate 'Selenium::WebDriver::IE#driver_path',
-                                   'Selenium::WebDriver::IE::Service#driver_path',
-                                   id: :driver_path
-        Selenium::WebDriver::IE::Service.driver_path
-      end
     end # IE
   end # WebDriver
 end # Selenium
diff --git a/rb/lib/selenium/webdriver/safari.rb b/rb/lib/selenium/webdriver/safari.rb
@@ -53,20 +53,6 @@ def path
 
           raise Error::WebDriverError, 'Unable to find Safari'
         end
-
-        def driver_path=(path)
-          WebDriver.logger.deprecate 'Selenium::WebDriver::Safari#driver_path=',
-                                     'Selenium::WebDriver::Safari::Service#driver_path=',
-                                     id: :driver_path
-          Selenium::WebDriver::Safari::Service.driver_path = path
-        end
-
-        def driver_path
-          WebDriver.logger.deprecate 'Selenium::WebDriver::Safari#driver_path',
-                                     'Selenium::WebDriver::Safari::Service#driver_path',
-                                     id: :driver_path
-          Selenium::WebDriver::Safari::Service.driver_path
-        end
       end
     end # Safari
   end # WebDriver

diff --git a/rb/spec/unit/selenium/webdriver/chrome/service_spec.rb b/rb/spec/unit/selenium/webdriver/chrome/service_spec.rb
@@ -70,22 +70,6 @@ module WebDriver
           expect(service.executable_path).to eq path
         end
 
-        it 'accepts Chrome#driver_path= and Chrome#driver_path but throws deprecation notices' do
-          path = '/path/to/driver'
-
-          expect {
-            Selenium::WebDriver::Chrome.driver_path = path
-          }.to have_deprecated(:driver_path)
-
-          expect {
-            expect(Selenium::WebDriver::Chrome.driver_path).to eq path
-          }.to have_deprecated(:driver_path)
-
-          service = Service.chrome
-
-          expect(service.executable_path).to eq path
-        end
-
         it 'does not create args by default' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 

diff --git a/rb/spec/unit/selenium/webdriver/firefox/service_spec.rb b/rb/spec/unit/selenium/webdriver/firefox/service_spec.rb
@@ -68,22 +68,6 @@ module WebDriver
           expect(service.executable_path).to eq path
         end
 
-        it 'accepts Firefox#driver_path= but throws deprecation notice' do
-          path = '/path/to/driver'
-
-          expect {
-            Selenium::WebDriver::Firefox.driver_path = path
-          }.to have_deprecated(:driver_path)
-
-          expect {
-            expect(Selenium::WebDriver::Firefox.driver_path).to eq path
-          }.to have_deprecated(:driver_path)
-
-          service = Service.firefox
-
-          expect(service.executable_path).to eq path
-        end
-
         it 'does not create args by default' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 

diff --git a/rb/spec/unit/selenium/webdriver/ie/service_spec.rb b/rb/spec/unit/selenium/webdriver/ie/service_spec.rb
@@ -69,22 +69,6 @@ module WebDriver
           expect(service.executable_path).to eq path
         end
 
-        it 'accepts IE#driver_path= but throws deprecation notice' do
-          path = '/path/to/driver'
-
-          expect {
-            Selenium::WebDriver::IE.driver_path = path
-          }.to have_deprecated(:driver_path)
-
-          expect {
-            expect(Selenium::WebDriver::IE.driver_path).to eq path
-          }.to have_deprecated(:driver_path)
-
-          service = Service.ie
-
-          expect(service.executable_path).to eq path
-        end
-
         it 'does not create args by default' do
           allow(Platform).to receive(:find_binary).and_return(service_path)
 

diff --git a/rb/spec/unit/selenium/webdriver/safari/service_spec.rb b/rb/spec/unit/selenium/webdriver/safari/service_spec.rb
@@ -70,22 +70,6 @@ module WebDriver
           expect(service.executable_path).to eq path
         end
 
-        it 'accepts Safari#driver_path= but throws deprecation notice' do
-          path = '/path/to/driver'
-
-          expect {
-            Selenium::WebDriver::Safari.driver_path = path
-          }.to have_deprecated(:driver_path)
-
-          expect {
-            expect(Selenium::WebDriver::Safari.driver_path).to eq path
-          }.to have_deprecated(:driver_path)
-
-          service = Service.safari
-
-          expect(service.executable_path).to eq path
-        end
-
         it 'does not create args by default' do
           allow(Platform).to receive(:find_binary).and_return(service_path)