Skip to content

Commit

Permalink
[js] Marionette support: Remove dev edition enforcement (#2135)
Browse files Browse the repository at this point in the history
  • Loading branch information
JohanLorenzo authored and jleyba committed May 24, 2016
1 parent 1019ef2 commit e3a896b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
1 change: 1 addition & 0 deletions javascript/node/selenium-webdriver/CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* Added new wait conditions: `until.urlIs()`, `until.urlContains()`,
`until.urlMatches()`
* Added work around for [GeckoDriver bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1274924) raising a type conversion error
* Removed the mandatory use of Firefox Dev Edition, when using Marionette driver

## v2.53.2

Expand Down
10 changes: 2 additions & 8 deletions javascript/node/selenium-webdriver/firefox/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,14 +275,8 @@ function findGeckoDriver() {
* @return {!remote.DriverService} .
*/
function createGeckoDriverService(binary) {
// Firefox's Developer Edition is currently required for Marionette.
let exe;
if (typeof binary === 'string') {
exe = Promise.resolve(binary);
} else {
binary.useDevEdition();
exe = binary.locate();
}
let exe = typeof binary === 'string' ?
Promise.resolve(binary) : binary.locate();

let geckoDriver = findGeckoDriver();
let port = portprober.findFreePort();
Expand Down

0 comments on commit e3a896b

Please sign in to comment.