[js] Marionette support: Remove dev edition enforcement #2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (typeof binary === 'string') { | ||
| exe = Promise.resolve(binary); | ||
| } else { | ||
| binary.useDevEdition(); |
There was a problem hiding this comment.
This is the only line you should remove (forcing users to dev edition for marionette). Users should still be able to opt-in to the dev edition if they want it.
There was a problem hiding this comment.
Works for me! Done.
|
Could you add a point to CHANGES.md? I try to keep that in sync with changes. |
|
Sorry, I merged your PRs in the wrong order. Mind fixing the merge conflicts? |
|
No problem! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on 185755a. Firefox 46 is now in the release channel. We don't need to rely on Dev Edition by default anymore.
I tested this removal on Mac OS X against Firefox Beta (currently 47, it'll enter release on June 7th).
git grep useDevEditiondidn't return any other place where it was used.Would you like to review @jleyba @AutomatedTester ?
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement