#1262 renamed ISSUE_COMMENT to NEW_COMMENT for better semantics

self-xdsd · Oct 30, 2021 · 3c96674 · 3c96674
1 parent cfe1fb2
commit 3c96674
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/self-api/src/main/java/com/selfxdsd/api/Event.java b/self-api/src/main/java/com/selfxdsd/api/Event.java
@@ -106,7 +106,7 @@ private Type(){}
         /**
          * Event for a comment.
          */
-        public static final String ISSUE_COMMENT = "comment_created";
+        public static final String NEW_COMMENT = "comment_created";
 
         /**
          * Event for renaming a repo.

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/projects/GithubWebhookEvent.java b/self-core-impl/src/main/java/com/selfxdsd/core/projects/GithubWebhookEvent.java
@@ -91,7 +91,7 @@ public String type() {
         } else if ("issue_comment".equalsIgnoreCase(type)) {
             final String act = event.getString("action");
             if("created".equalsIgnoreCase(act)) {
-                resolved = Type.ISSUE_COMMENT;
+                resolved = Type.NEW_COMMENT;
             } else {
                 resolved = type;
             }

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/projects/GitlabWebhookEvent.java b/self-core-impl/src/main/java/com/selfxdsd/core/projects/GitlabWebhookEvent.java
@@ -106,7 +106,7 @@ public String type() {
             ).getString("noteable_type", "");
             if("Issue".equalsIgnoreCase(noteableType)
                 || "MergeRequest".equalsIgnoreCase(noteableType)) {
-                resolved = Type.ISSUE_COMMENT;
+                resolved = Type.NEW_COMMENT;
             } else {
                 resolved = this.type;
             }

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java b/self-core-impl/src/main/java/com/selfxdsd/core/projects/StoredProject.java
@@ -190,7 +190,7 @@ public void resolve(final Event event) {
             case Event.Type.ASSIGNED_TASKS:
                 this.projectManager.assignedTasks(event);
                 break;
-            case Event.Type.ISSUE_COMMENT:
+            case Event.Type.NEW_COMMENT:
                 this.projectManager.comment(event);
                 break;
             case Event.Type.REPO_RENAMED:

diff --git a/self-core-impl/src/test/java/com/selfxdsd/core/projects/GithubWebhookEventTestCase.java b/self-core-impl/src/test/java/com/selfxdsd/core/projects/GithubWebhookEventTestCase.java
@@ -447,7 +447,7 @@ public void returnsIssueCommentType() {
         );
         MatcherAssert.assertThat(
             event.type(),
-            Matchers.equalTo(Event.Type.ISSUE_COMMENT)
+            Matchers.equalTo(Event.Type.NEW_COMMENT)
         );
     }
 }
diff --git a/self-core-impl/src/test/java/com/selfxdsd/core/projects/GitlabWebhookEventTestCase.java b/self-core-impl/src/test/java/com/selfxdsd/core/projects/GitlabWebhookEventTestCase.java
@@ -230,7 +230,7 @@ public void typeIssueCommentForIssueComment() {
         );
         MatcherAssert.assertThat(
             gitlabEvent.type(),
-            Matchers.equalTo(Event.Type.ISSUE_COMMENT)
+            Matchers.equalTo(Event.Type.NEW_COMMENT)
         );
     }
 
@@ -251,7 +251,7 @@ public void typeIssueCommentForMergeRequestComment() {
         );
         MatcherAssert.assertThat(
             gitlabEvent.type(),
-            Matchers.equalTo(Event.Type.ISSUE_COMMENT)
+            Matchers.equalTo(Event.Type.NEW_COMMENT)
         );
     }