#1198 added 'repository' event to GithubWebhooks

self-xdsd · Aug 10, 2021 · 86a0f26 · 86a0f26 · zoeself · Aug 10, 2021
1 parent ad07e3e
commit 86a0f26
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/self-api/src/main/java/com/selfxdsd/api/Collaborators.java b/self-api/src/main/java/com/selfxdsd/api/Collaborators.java
@@ -27,6 +27,9 @@
  * @author Mihai Andronache (amihaiemil@gmail.com)
  * @version $Id$
  * @since 0.0.13
+ * @todo #1198:60min Elevate the PMs repo permissions when sending the
+ *  invitation. At the moment the PM has Write permissions which seems to not be
+ *  enough in order to add/remove Webhooks.
  */
 public interface Collaborators extends Iterable<Collaborator> {
 

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/GithubWebhooks.java b/self-core-impl/src/main/java/com/selfxdsd/core/GithubWebhooks.java
@@ -44,9 +44,6 @@
  * @author Mihai Andronache (amihaiemil@gmail.com)
  * @version $Id$
  * @since 0.0.13
- * @todo #1196:60min When registering the Project webhook, make sure to also add
- *  the Repo Rename event to it. After that we might have to do it for Gitlab
- *  as well.
  */
 final class GithubWebhooks implements Webhooks {
 
@@ -105,6 +102,7 @@ public boolean add(final Project project) {
                         .add("issue_comment")
                         .add("pull_request")
                         .add("push")
+                        .add("repository")
                 )
                 .add(
                     "config",

diff --git a/self-core-impl/src/test/java/com/selfxdsd/core/GithubWebhooksTestCase.java b/self-core-impl/src/test/java/com/selfxdsd/core/GithubWebhooksTestCase.java
@@ -77,6 +77,7 @@ public void addsWebhookCreated() {
                                         .add("issue_comment")
                                         .add("pull_request")
                                         .add("push")
+                                        .add("repository")
                                 )
                                 .add(
                                     "config",
@@ -147,6 +148,7 @@ public void addsWebhookNotFound() {
                                         .add("issue_comment")
                                         .add("pull_request")
                                         .add("push")
+                                        .add("repository")
                                 )
                                 .add(
                                     "config",