#1199 GithubWebhookEvent.repoNewName() implemented and tested

self-xdsd · Aug 9, 2021 · 96a0dc8 · 96a0dc8
1 parent 34fbb33
commit 96a0dc8
Show file tree

Hide file tree

Showing 10 changed files with 138 additions and 0 deletions.
diff --git a/self-api/src/main/java/com/selfxdsd/api/Event.java b/self-api/src/main/java/com/selfxdsd/api/Event.java
@@ -56,6 +56,12 @@ public interface Event {
      */
     Commit commit();
 
+    /**
+     * New name (simple name, without owner) of the Repo.
+     * @return String if this event is REPO_ENAMED, null otherwise.
+     */
+    String repoNewName();
+
     /**
      * Project where this event occured.
      * @return Project.

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/BitbucketRepo.java b/self-core-impl/src/main/java/com/selfxdsd/core/BitbucketRepo.java
@@ -103,6 +103,11 @@ public Commit commit() {
                     );
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/GithubRepo.java b/self-core-impl/src/main/java/com/selfxdsd/core/GithubRepo.java
@@ -104,6 +104,11 @@ public Commit commit() {
                     );
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/GitlabRepo.java b/self-core-impl/src/main/java/com/selfxdsd/core/GitlabRepo.java
@@ -126,6 +126,11 @@ public Commit commit() {
                     );
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/managers/Understand.java b/self-core-impl/src/main/java/com/selfxdsd/core/managers/Understand.java
@@ -75,6 +75,11 @@ public Commit commit() {
                     return event.commit();
                 }
 
+                @Override
+                public String repoNewName() {
+                    return event.repoNewName();
+                }
+
                 @Override
                 public Project project() {
                     return event.project();

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/projects/GithubWebhookEvent.java b/self-core-impl/src/main/java/com/selfxdsd/core/projects/GithubWebhookEvent.java
@@ -136,6 +136,18 @@ public Commit commit() {
         return commit;
     }
 
+    @Override
+    public String repoNewName() {
+        final String repoNewName;
+        if(Type.REPO_RENAMED.equalsIgnoreCase(this.type())) {
+            repoNewName = this.event.getJsonObject("repository")
+                .getString("name");
+        } else {
+            repoNewName = null;
+        }
+        return repoNewName;
+    }
+
     @Override
     public Project project() {
         return project;

diff --git a/self-core-impl/src/main/java/com/selfxdsd/core/projects/GitlabWebhookEvent.java b/self-core-impl/src/main/java/com/selfxdsd/core/projects/GitlabWebhookEvent.java
@@ -220,6 +220,13 @@ public Commit commit() {
         return commit;
     }
 
+    @Override
+    public String repoNewName() {
+        throw new UnsupportedOperationException(
+            "GitLab doesn't support Webhook for REPO_RENAMED!"
+        );
+    }
+
     @Override
     public Project project() {
         return this.project;

diff --git a/self-core-impl/src/test/java/com/selfxdsd/core/managers/StoredProjectManagerTestCase.java b/self-core-impl/src/test/java/com/selfxdsd/core/managers/StoredProjectManagerTestCase.java
@@ -459,6 +459,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -530,6 +535,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -609,6 +619,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -690,6 +705,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -765,6 +785,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -843,6 +868,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -923,6 +953,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -1004,6 +1039,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;

diff --git a/self-core-impl/src/test/java/com/selfxdsd/core/managers/UnderstandTestCase.java b/self-core-impl/src/test/java/com/selfxdsd/core/managers/UnderstandTestCase.java
@@ -89,6 +89,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;
@@ -148,6 +153,11 @@ public Commit commit() {
                     return null;
                 }
 
+                @Override
+                public String repoNewName() {
+                    return null;
+                }
+
                 @Override
                 public Project project() {
                     return project;

diff --git a/self-core-impl/src/test/java/com/selfxdsd/core/projects/GithubWebhookEventTestCase.java b/self-core-impl/src/test/java/com/selfxdsd/core/projects/GithubWebhookEventTestCase.java
@@ -115,6 +115,49 @@ public void returnsRepoRenameType() {
         );
     }
 
+    /**
+     * GithubWebhookEvent can return the repoNewName if the type is
+     * REPO_RENAMED.
+     */
+    @Test
+    public void returnsRepoNewNameIfTypeRenamed() {
+        final Project project = Mockito.mock(Project.class);
+        final Event event = new GithubWebhookEvent(
+            project,
+            "repository",
+            Json.createObjectBuilder()
+                .add("action", "renamed")
+                .add(
+                    "repository",
+                    Json.createObjectBuilder()
+                        .add("name", "new_name")
+                        .build()
+                ).build().toString()
+        );
+        MatcherAssert.assertThat(
+            event.repoNewName(),
+            Matchers.equalTo("new_name")
+        );
+    }
+
+    /**
+     * GithubWebhookEvent returns null repoNewName if type is not REPO_RENAMED.
+     */
+    @Test
+    public void returnsNullRepoNewNameIfTypeNotRenamed() {
+        final Project project = Mockito.mock(Project.class);
+        final Event event = new GithubWebhookEvent(
+            project,
+            "repository",
+            Json.createObjectBuilder()
+                .add("action", "publicised")
+                .build().toString()
+        );
+        MatcherAssert.assertThat(
+            event.repoNewName(),
+            Matchers.nullValue()
+        );
+    }
 
     /**
      * GithubWebhookEvent can return the newIssue PR type.