Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Change Webhooks On REPO_RENAME #1208

Closed
amihaiemil opened this issue Aug 10, 2021 · 3 comments · Fixed by #1209
Closed

Don't Change Webhooks On REPO_RENAME #1208

amihaiemil opened this issue Aug 10, 2021 · 3 comments · Fixed by #1209
Labels
bug Something isn't working

Comments

@amihaiemil
Copy link
Member

Apparently changing the webhook on REPO_RENAME is not an option because this will only work for Organization Repos. For Personal Repos, the PM cannot have the required permissions.

Let's leave the Webhook as it is change the logic in Self PM (we will select the Project by the secret key, which is sure to be unique accross all projects).

@amihaiemil amihaiemil added the bug Something isn't working label Aug 10, 2021
@amihaiemil amihaiemil self-assigned this Aug 10, 2021
@zoeself
Copy link
Collaborator

zoeself commented Aug 10, 2021

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2021-08-20T10:45:46.157613.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

@zoeself
Copy link
Collaborator

zoeself commented Aug 10, 2021

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

amihaiemil added a commit to amihaiemil/self-core that referenced this issue Aug 10, 2021
amihaiemil added a commit to amihaiemil/self-core that referenced this issue Aug 10, 2021
amihaiemil added a commit that referenced this issue Aug 10, 2021
#1208 remove Webhook change from StoredProject.rename(...)
@zoeself
Copy link
Collaborator

zoeself commented Aug 10, 2021

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants