-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't Change Webhooks On REPO_RENAME #1208
Comments
@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is Estimation here is Remember, you don't have to solve everything in this ticket - you can solve it partially and leave If you have any questions don't ask me, I'm not a technical person. Open new tickets instead. If you don't have time or simply don't want to work on this, you can always resign. |
@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee. |
#1208 remove Webhook change from StoredProject.rename(...)
@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
Apparently changing the webhook on REPO_RENAME is not an option because this will only work for Organization Repos. For Personal Repos, the PM cannot have the required permissions.
Let's leave the Webhook as it is change the logic in Self PM (we will select the Project by the secret key, which is sure to be unique accross all projects).
The text was updated successfully, but these errors were encountered: