Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set User-Agent Header #1258

Closed
amihaiemil opened this issue Oct 16, 2021 · 3 comments · Fixed by #1259
Closed

Set User-Agent Header #1258

amihaiemil opened this issue Oct 16, 2021 · 3 comments · Fixed by #1259

Comments

@amihaiemil
Copy link
Member

As per Github API documentation, we should set a descriptive User-Agent http header on any request.

@amihaiemil amihaiemil self-assigned this Oct 16, 2021
@zoeself
Copy link
Collaborator

zoeself commented Oct 16, 2021

@amihaiemil this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2021-10-26T12:55:38.822221.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

@zoeself
Copy link
Collaborator

zoeself commented Oct 16, 2021

@amihaiemil please keep in mind that manual assignment of tickets is a bad practice and it is discouraged. Next time, please let me elect the assignee.

amihaiemil added a commit to amihaiemil/self-core that referenced this issue Oct 16, 2021
amihaiemil added a commit that referenced this issue Oct 16, 2021
#1258 set User-Agent header properly
@zoeself
Copy link
Collaborator

zoeself commented Oct 16, 2021

@amihaiemil thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants