Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemoryInvoices.java:19-23: Refactor and test... #175

Closed
0pdd opened this issue Jun 7, 2020 · 4 comments
Closed

InMemoryInvoices.java:19-23: Refactor and test... #175

0pdd opened this issue Jun 7, 2020 · 4 comments
Assignees
@criske
Labels
bounty: $10 @criske

Comments

@0pdd
Copy link

0pdd commented Jun 7, 2020

The puzzle 165-63222a61 from #165 has to be resolved:

self-core/self-core-impl/src/test/java/com/selfxdsd/core/mock/InMemoryInvoices.java

Lines 19 to 23 in 101eccc

* @todo #165:30min Refactor and test ContractInvoices to be part
* of self-impl API .
* Also InvoiceTask should have its own concrete implementation in self-impl.
* Use that in InMemoryInvoices.
* Continue testing InMemoryInvoices.

The puzzle was created by cristianpela on 07-Jun-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Author

0pdd commented Jun 7, 2020

@amihaiemil please pay attention to this new issue.

@0pdd 0pdd added the pdd label Jun 7, 2020
@criske
Copy link
Contributor

criske commented Jun 8, 2020

I'll work on this.
I'll focus on testing and leave refactoring part for another puzzle, if that's ok.

criske added a commit to criske/self-core that referenced this issue Jun 8, 2020
@criske
self-xdsd#175 - Finished testing InMemoryInvoices.
b23b0cf 
Left puzzle to refactor and test ContractInvoices.
@criske criske mentioned this issue Jun 8, 2020
Merged
@0pdd
Copy link
Author

0pdd commented Jun 8, 2020

The puzzle 165-63222a61 has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

@0pdd 0pdd closed this as completed Jun 8, 2020
@amihaiemil
Copy link
Member

paid with transaction id 1BD17495F00273448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criske criske

Labels
bounty: $10 @criske
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amihaiemil @criske @0pdd