Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StoredInvoice.java:13-16: Remove the first constructor,... #412

Closed
0pdd opened this issue Aug 16, 2020 · 2 comments
Closed

StoredInvoice.java:13-16: Remove the first constructor,... #412

0pdd opened this issue Aug 16, 2020 · 2 comments
Assignees
@amihaiemil
Labels
@amihaiemil

Comments

@0pdd
Copy link

0pdd commented Aug 16, 2020

The puzzle 410-bc32691d from #410 has to be resolved:

self-core/self-core-impl/src/main/java/com/selfxdsd/core/contracts/invoices/StoredInvoice.java

Lines 13 to 16 in 0728a22

* @todo #410:30min Remove the first constructor, since it is not needed.
* When creating an Invoice, we'll make an INSERT via JOOQ, which means
* this constructor is only needed for the InMemoryInvoices (which is just
* present for scaffolding reasons and will be removed later).

The puzzle was created by amihaiemil on 16-Aug-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Author

0pdd commented Aug 16, 2020

@amihaiemil please pay attention to this new issue.

@0pdd 0pdd added the pdd label Aug 16, 2020
@amihaiemil amihaiemil mentioned this issue Aug 16, 2020
Closed
@amihaiemil amihaiemil self-assigned this Aug 16, 2020
amihaiemil added a commit to amihaiemil/self-core that referenced this issue Aug 16, 2020
@amihaiemil
self-xdsd#412 StoredInvoice: removed useless ctor
da28136
amihaiemil added a commit to amihaiemil/self-core that referenced this issue Aug 16, 2020
@amihaiemil
self-xdsd#412 removed puzzle
753e218
@amihaiemil amihaiemil mentioned this issue Aug 16, 2020
Merged
amihaiemil added a commit that referenced this issue Aug 16, 2020
@amihaiemil
Merge pull request #413 from amihaiemil/412
c3c7c48 
#412 StoredInvoice: removed useless constructor
@0pdd 0pdd closed this as completed Aug 16, 2020
@0pdd
Copy link
Author

0pdd commented Aug 16, 2020

The puzzle 410-bc32691d has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amihaiemil amihaiemil

Labels
@amihaiemil
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amihaiemil @0pdd