Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand.java:39-41: Add the Confused implementation of... #451

Closed
0pdd opened this issue Aug 19, 2020 · 5 comments
Closed

Understand.java:39-41: Add the Confused implementation of... #451

0pdd opened this issue Aug 19, 2020 · 5 comments

Comments

@0pdd
Copy link

0pdd commented Aug 19, 2020

The puzzle 446-a770e22e from #446 has to be resolved:

* @todo #446:30min Add the Confused implementation of Conversation,
* which will send a "didn't understand" reply, if the event type is
* "confused".

The puzzle was created by amihaiemil on 19-Aug-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Author

0pdd commented Aug 19, 2020

@amihaiemil please pay attention to this new issue.

@0pdd 0pdd added the pdd label Aug 19, 2020
@amihaiemil
Copy link
Member

amihaiemil commented Aug 19, 2020

@criske Wanna take this one? It's not complicated, just see how the Hello conversation is implemented.
The only difference is, the Confused conversation will be the last one in the chain, so it won't encapsulate any next Conversation.

The Confused conversation should simply build and return a SendReply step, with a reply message saying something like "@author Sorry, I did not understand that"

@criske
Copy link
Contributor

criske commented Aug 19, 2020

@amihaiemil sure

criske added a commit to criske/self-core that referenced this issue Aug 19, 2020
criske added a commit to criske/self-core that referenced this issue Aug 19, 2020
- removed unnecessary String.format.
criske added a commit to criske/self-core that referenced this issue Aug 19, 2020
- added author argument to the 'misunderstand.comment'.
@amihaiemil
Copy link
Member

paid with transaction id 23193855XX8306448

@0pdd 0pdd closed this as completed Aug 19, 2020
@0pdd
Copy link
Author

0pdd commented Aug 19, 2020

The puzzle 446-a770e22e has disappeared from the source code, that's why I closed this issue. //cc @amihaiemil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants