Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1269 Send a comment after updating task estimation. #1283

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

criske
Copy link
Contributor

@criske criske commented Nov 10, 2021

This logic will be tested along with #1271.

Pr for #1269

@zoeself
Copy link
Collaborator

zoeself commented Nov 10, 2021

@criske thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@criske
Copy link
Contributor Author

criske commented Nov 10, 2021

@amihaiemil no bounty for this :D

@@ -665,8 +663,7 @@ public void issueLabelsChanged(final Event event) {
isNotClosed -> new TaskIsRegistered(
new IssueEstimationChanged(
new UpdateTaskEstimation(
sendReply -> LOG.debug("Send updated estimation"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil btw, is there a "Log" step? It will be nice to retain this info too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@criske nope, but I'm pretty sure SendReply does some logging internally :D

@zoeself
Copy link
Collaborator

zoeself commented Nov 10, 2021

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@amihaiemil amihaiemil merged commit 0de74ab into self-xdsd:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants