#1271 Reply with estimation changed value. #1284
Conversation
- Unignored test - Updated Step api to be able to receive data from the previous Step in chain.
|
@criske thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
|
@amihaiemil I think with this aproach we can send the new estimation from |
|
@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role Please, make sure there is at least one available contributor with the required role and the project can afford to pay them. |
|
@criske scuze, am uitat de API-u Event si faptu ca nu prea avem acces usor la vechea estimare in contextul de fata. As renunta la SendReply in cazul asta si as folosi functie anonima, ca in alte cazuri, de exemplu aici. Sincer nici nu mai stiu acum la ce e folosit SendReply (vad ca in manager nu e folosit nicaieri) :D Iar textul sa fie doar: "Estimation changed to X min at Timestamp" (poti lua noua estimare din event.issue().estimation()) Si pt text efectiv foloseste project.language(), sa fie traductibil : D Altfel treaba asta cu derive, nu prea vad la ce am folosi-o. Poate ramane ca PoC pt viitor : D |
|
@criske a, SendReply cred ca e folosit doar cand raspunde la un Comment, sa appenduiasca acolo si Comment-ul anterior. Legat de asta cu derive(...) - nu cred ca e o idee buna, desi la prima vedere mi se pare sexy. Ideea ar fi ca un Step sa lucreze doar cu Event-ul, de acolo sa isi ia datele cu care lucreaza, exclusiv :D |
|
@amihaiemil ah ok, pai daca e nevoie doar de noua estimare in comment atunci se simplifica lucrurile... ii dau revert si o sa folosesc un lambda in loc de |
- reverted changes to Step API
| MatcherAssert.assertThat(commentCaptor.getValue(), Matchers | ||
| .startsWith("Estimation changed to ``30`` minutes at ``20")); |
There was a problem hiding this comment.
//TODO we'll need to fix this test in 2100 :D
There was a problem hiding this comment.
took me a while to understand haha
Pr for #1271