Started the delete of payout methods #397
Conversation
|
@Lumi3011 thank you for your Pull Request. I'll assign someone to review it soon. |
|
@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role Please, make sure there is at least one available contributor with the required role and the project can afford to pay them. |
|
@amihaiemil When you have time please checkout what I have done for the payout method. I've done the pull request because I need some help with this, because when I press the delete button I get the stripe page and I don't know why. If you have time to help me I will done the modifications and I'll push directly here. Thanks :D |
| @@ -16,7 +16,7 @@ $(document).ready( | |||
| } | |||
| } | |||
| ); | |||
| $("#createStripeConnectAccountForm").submit( | |||
| $("#create ConnectAccountForm").submit( | |||
There was a problem hiding this comment.
@Lumi3011 Aici sigur nu trebuie modificat :D Pune cum era inainte pls.
There was a problem hiding this comment.
Scuze, am facut-o din greseala la un copy paste al unei clase si nu vazusem
| @@ -130,6 +130,34 @@ $(document).ready( | |||
| ); | |||
| } | |||
| ); | |||
| $('#stripeDeleteButton').submit( | |||
There was a problem hiding this comment.
@Lumi3011 Aici ar trebui ID-ul form-ului in care se afla butonul. Vezi mai jos :D
| @@ -353,6 +353,9 @@ <h4>Account ID: <span id="accountId"></span></h4> | |||
| <button id="stripeDashboardButton" type="submit" class="btn btn-primary"> | |||
| Stripe Dashboard | |||
| </button> | |||
| <button id="stripeDeleteButton" type="submit" class="btn btn-primary"> | |||
| Delete | |||
| </button> | |||
There was a problem hiding this comment.
@Lumi3011 Butonul asta trebuie sa fie in propriul lui <form></form> element, de aia nu merge cum trebuie.
Apesi pe el si ti se deschide dashboard-ul de Stripe deoarece in momentul de fata se afla in <form>-ul de stripe dashboard, care are deja listener-ul lui.
In principiu orice buton care face submit trebuie intotdeauna sa se afle in propriul form. Chiar daca este un formular fara field-uri, el tot submit face, la un formular gol :D
EDIT: am putea face si fara <form>, sa adaugam direct un listener onClick pe buton. Dar am ales varianta cu form deoarece e mai directa oarecum, are jQuery metoda de .submit({...}) aplicata pe formular si salut, isi face treaba :D
There was a problem hiding this comment.
Ok, am inteles, nu am lucrat cu form-uri prea mult si nu stiam asta.
|
@Lumi3011 arata bine, mersi! |
|
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 4min) |
Delete button for the payout methods #387