Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 TodosSerializer implemented + tested for json. #11

Merged
merged 3 commits into from
Nov 14, 2020

Conversation

criske
Copy link
Contributor

@criske criske commented Nov 13, 2020

closes #5

@charlesmike
Copy link

@criske thank you for your Pull Request. I'll assign someone to review it soon.

final JsonArrayBuilder array = Json.createArrayBuilder();
for (final Todo todo : todos) {
final JsonObject object = Json.createObjectBuilder()
.add("ticket", todo.getTicketID())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil I'll update with proper abstraction when #4 is resolved.

@charlesmike
Copy link

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@@ -99,12 +99,12 @@ public URI serialize() {
private File getFile(final boolean deleteFirst) throws URISyntaxException,
IOException {
//folder where application is running.
final String parent = JsonTodosSerializer.class
final String parent = new File(JsonTodosSerializer.class
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil todos.json is now created in the same folder of the app jar (tested manually).

@amihaiemil
Copy link
Member

@rultor merge it please

@rultor
Copy link
Collaborator

rultor commented Nov 14, 2020

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit a297672 into self-xdsd:master Nov 14, 2020
@rultor
Copy link
Collaborator

rultor commented Nov 14, 2020

@rultor merge it please

@amihaiemil Done! FYI, the full log is here (took me 3min)

@criske criske deleted the issue5 branch November 18, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output in file todos.json
4 participants