-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5 TodosSerializer implemented + tested for json. #11
Conversation
@criske thank you for your Pull Request. I'll assign someone to review it soon. |
final JsonArrayBuilder array = Json.createArrayBuilder(); | ||
for (final Todo todo : todos) { | ||
final JsonObject object = Json.createObjectBuilder() | ||
.add("ticket", todo.getTicketID()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil I'll update with proper abstraction when #4 is resolved.
@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role Please, make sure there is at least one available contributor with the required role and the project can afford to pay them. |
- fixed running folder path
@@ -99,12 +99,12 @@ public URI serialize() { | |||
private File getFile(final boolean deleteFirst) throws URISyntaxException, | |||
IOException { | |||
//folder where application is running. | |||
final String parent = JsonTodosSerializer.class | |||
final String parent = new File(JsonTodosSerializer.class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil todos.json is now created in the same folder of the app jar (tested manually).
@rultor merge it please |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 3min) |
closes #5