Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7 TodoVisitor accepts js files too. #12

Merged
merged 1 commit into from
Nov 14, 2020
Merged

Conversation

criske
Copy link
Contributor

@criske criske commented Nov 14, 2020

closes #7

@charlesmike
Copy link

@criske thank you for your Pull Request. I'll assign someone to review it soon.

@criske
Copy link
Contributor Author

criske commented Nov 14, 2020

@amihaiemil no bounty needed.

@charlesmike
Copy link

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@amihaiemil
Copy link
Member

@criske thank you!

@amihaiemil
Copy link
Member

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Nov 14, 2020

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Nov 14, 2020

@rultor merge it

@amihaiemil @criske Oops, I failed. You can see the full log here (spent 3min)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 30561
+ echo '1.69.1 839260fab'
1.69.1 839260fab
+ date
Sat Nov 14 17:50:55 CET 2020
+ uptime
 17:50:55 up 48 days,  2:56,  0 users,  load average: 0.00, 0.01, 0.00
+ ff=default
+ image=g4s8/rultor-jdk11:alpine3.10
+ rebase=false
+ head_branch=master
+ pull_title='#7 TodoVisitor accepts js files too.'
+ author=amihaiemil
+ directory=
+ head=git@github.com:self-xdsd/todo-finder-cli.git
+ pull_id=12
+ fork=git@github.com:criske/todo-finder-cli.git
+ fork_branch=issue7
+ squash=false
+ vars=('--env=JAVA_HOME=/usr/lib/jvm/java-11-openjdk' '--env=head=git@github.com:self-xdsd/todo-finder-cli.git' '--env=pull_id=12' '--env=fork=git@github.com:criske/todo-finder-cli.git' '--env=fork_branch=issue7' '--env=head_branch=master' '--env=pull_title=#7 TodoVisitor accepts js files too.' '--env=author=amihaiemil' '--env=scripts=( '\''export '\''\'\'''\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head=git@github.com:self-xdsd/todo-finder-cli.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_id=12'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork=git@github.com:criske/todo-finder-cli.git'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''fork_branch=issue7'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''head_branch=master'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''pull_title=#7 TodoVisitor accepts js files too.'\''\'\'''\'''\'' '\'';'\'' '\''export '\''\'\'''\''author=amihaiemil'\''\'\'''\'''\'' '\'';'\'' '\''mvn clean install -Pcheckstyle'\'' '\'';'\'' )')
+ scripts=('export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ';' 'export '\''head=git@github.com:self-xdsd/todo-finder-cli.git'\''' ';' 'export '\''pull_id=12'\''' ';' 'export '\''fork=git@github.com:criske/todo-finder-cli.git'\''' ';' 'export '\''fork_branch=issue7'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#7 TodoVisitor accepts js files too.'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';')
+ container=self-xdsd_todo-finder-cli_12
+ as_root=false
+ mkdir -p /home/rultor/.ssh
+ echo -e 'Host github.com\n\tStrictHostKeyChecking no\n'
+ chmod 600 /home/rultor/.ssh/config
+ git clone git@github.com:self-xdsd/todo-finder-cli.git repo
Cloning into 'repo'...
+ cd repo
+ git config user.email me@rultor.com
+ git config user.name rultor
+ '[' -z 'export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ']'
+ cd ..
+ cat
+ '[' false = true ']'
+ cat
+ chmod a+x entry.sh
+ cat
+ echo 'export '\''JAVA_HOME=/usr/lib/jvm/java-11-openjdk'\''' ';' 'export '\''head=git@github.com:self-xdsd/todo-finder-cli.git'\''' ';' 'export '\''pull_id=12'\''' ';' 'export '\''fork=git@github.com:criske/todo-finder-cli.git'\''' ';' 'export '\''fork_branch=issue7'\''' ';' 'export '\''head_branch=master'\''' ';' 'export '\''pull_title=#7 TodoVisitor accepts js files too.'\''' ';' 'export '\''author=amihaiemil'\''' ';' 'mvn clean install -Pcheckstyle' ';'
+ sensitive=()
+ gpgconf --reload gpg-agent
+ gpg --keyserver hkp://pool.sks-keyservers.net --verbose --recv-keys 9AF0FA4C
gpg: requesting key 9AF0FA4C from hkp server pool.sks-keyservers.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
'cid' file is absent, container wasn't started correctly

@amihaiemil amihaiemil merged commit 72f51e6 into self-xdsd:master Nov 14, 2020
@criske criske deleted the issue7 branch November 18, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ".js" files to be parsed for todos.
4 participants