Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLF4J and Log4J logging support #15

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Add SLF4J and Log4J logging support #15

merged 1 commit into from
Nov 19, 2020

Conversation

lukacupic
Copy link
Contributor

@lukacupic lukacupic commented Nov 17, 2020

PR for #6

@charlesmike
Copy link

@lukacupic thank you for your Pull Request. I'll assign someone to review it soon.

@charlesmike
Copy link

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role REV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

@amihaiemil
Copy link
Member

@lukacupic Looks good. Just one remark: always add a description to your PR and reference the ticket you are solving. This is a small PR so I just referenced the ticket.

@amihaiemil
Copy link
Member

@rultor merge it please

@rultor
Copy link
Collaborator

rultor commented Nov 19, 2020

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit ff0d57d into self-xdsd:master Nov 19, 2020
@rultor
Copy link
Collaborator

rultor commented Nov 19, 2020

@rultor merge it please

@amihaiemil Done! FYI, the full log is here (took me 2min)

@lukacupic
Copy link
Contributor Author

@lukacupic Looks good. Just one remark: always add a description to your PR and reference the ticket you are solving. This is a small PR so I just referenced the ticket.

Understood, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants