-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add excerpts for currently defined words #262
Add excerpts for currently defined words #262
Conversation
@@ -2,6 +2,7 @@ | |||
title: Southeast Asian | |||
slug: southeast-asian | |||
defined: true | |||
excerpt: umbrella term for people of Southeast Asian descent; the two main subregions are Mainland Southeast Asia and Maritime Southeast Asia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure whether we should include a full list of countries here. For East Asian and South Asian I included the list of countries; however, the list of countries for Southeast Asian is significantly longer. I compromised here by providing the two main subregions, but I'm not sure how many people would be familiar with the countries within.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paging @tatianamac for feedback on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thejoycekung I LOVEEEEE that you're being mindful of this. In this instance since it's just for the excerpt, I think we're good.
11ty/definitions/bierasure.md
Outdated
@@ -3,6 +3,7 @@ title: Bierasure | |||
slug: bierasure | |||
speech: noun | |||
defined: true | |||
excerpt: the questioning or denial of the existance or legitimacy of bisexuality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This originally included a reference to the Bisexuality definition - I wasn't sure whether the link should be translated through.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link can be left out, as the excerpt will mostly be used for social media previews and there no links allowed there anyway :)
@thejoycekung We have finally merged the PR this is used for. Do I see it correctly that you’ve added all excerpts? You’re a hero. |
@ovlb That's great news! And yeah, I had the time so I figured I might as well finish it out :) |
That’s super awesome. Let’s wati for the open question to be resolved, and merge it once that’s done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING.
@@ -5,6 +5,7 @@ flag: | |||
text: 'ableist language' | |||
level: avoid | |||
defined: true | |||
excerpt: non-verbal, non-speaking, silent, refraining from speaking or unable to speak; sometimes __mute__ which can also be ableist; colloquially used to mean unintelligent or senseless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excerpt: non-verbal, non-speaking, silent, refraining from speaking or unable to speak; sometimes __mute__ which can also be ableist; colloquially used to mean unintelligent or senseless | |
excerpt: avoid. ableist. colloquially used to mean unintelligent or senseless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We add avoid in the template already, I think by adding it to the excerpt it will show up twice.
@thejoycekung This was SOOOO incredible. Thank you SO much for writing all this. I added a few suggestions which you can take or leave (the approval is not contingent on these changes, except maybe the spelling error.) Reach out if you want to discuss any of the edits or get clarification. Immensely grateful for you and this PR! |
Co-authored-by: Tatiana Mac <github@tatianamac.com>
Co-authored-by: Tatiana Mac <github@tatianamac.com>
Co-authored-by: Tatiana Mac <github@tatianamac.com>
@tatianamac Thanks for the review! I took your suggestions - I love the idea of using the flag level in the excerpt and it really does help summarize the term's usage a lot better. |
That’s something we do automatically already. E.g. for derpy avoid now shows up twice: What’s missing from the automatic version is the flag content, e.g. ableist term. But we should add this, to reduce manual work when writing the excerpts. |
Oh, whoops. Thanks for the reminder @ovlb. @thejoycekung I am sorry for the extra work! |
This reverts commit a291d5f, because the flag level is already indicated in the excerpt structure.
@ovlb Oh that's a real good catch. Glad I did them all in one commit so it's easy to revert, haha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, @thejoycekung !
Fixes #224
I just went alphabetically for the most part. In some cases, I pulled the definition directly; in other cases I supplemented the definition with some of the issues/impacts with the term. Please let me know if I should just stick to the definition (or whether some of the other terms should be supplemented).
Missing:
-phobia
(there was no definition to pull from, and I didn't feel comfortable writing one)