Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R.none incorrectly returns true #625

Closed
dizney opened this issue Feb 21, 2022 · 4 comments
Closed

R.none incorrectly returns true #625

dizney opened this issue Feb 21, 2022 · 4 comments

Comments

@dizney
Copy link

dizney commented Feb 21, 2022

const result = R.none((input) => input > 1, [1, 2, 3]);

Would expect false as result but it is true. It seems like none returns true when any value in the list returns false instead of all.

selfrefactor added a commit that referenced this issue Feb 21, 2022
@selfrefactor
Copy link
Owner

Thank you so much for this issue. It is a big error, so I will try to make a release asap.

@selfrefactor
Copy link
Owner

I am closing the issue as a fix is released with 7.0.3. Again, thank you for taking the time to report this.

@dizney
Copy link
Author

dizney commented Feb 22, 2022

Thanks for the quick fix Dejan! 👍

@selfrefactor
Copy link
Owner

Just last note as this is serious mistake - the wrong logic was introduced with version 7.0.0, i.e. before that the method was working correctly. Also I found that there was an error in the script that checks Rambda methods against Ramda tests, so again thank you for spotting this out as it would otherwise go unnoticed.

selfrefactor added a commit that referenced this issue May 6, 2022
* fix@issue #619 wrong export declaration

* feat: remove r.is.function

* chore: remove circle ci

* feat: add r.modify.path

* fix: r.modify.path

* chore@dnd

* fix@typings r.nth

* fix: r.nth

* feat@dep update all

* feat: r.merge.with

* feat: r.juxt

* feat: r.mapcat

* feat: r.count.by

* feat: r.flatten.object

* feat: r.flatten.object is ready

* chore: lint

* feat@method r.delete.path

* feat@method r.unwind

* chore@dnd

* chore: update test script

* feat: initial pythonic list

* feat: list typings

* feat@typings r.init

* fix@issue #625 totally wrong r.none

* feat@method r.contains

* feat@method change r.count

* feat@method r.on

* feat@method r.where.any

* feat@method r.partial.object

* feat@important r.pipe

* fix@issue #612 deno support

* chore@dnd

* chore@dnd

* chore@dnd

* chore@lint all with new import rule

* chore@lint apply to src

* feat: rename r.merge

* fix@definition r.count.by

* fix: r.modify.path

* chore@dnd

* fix@typing r.on

* fix: typings test

* fix: r.none

* chore: build

* chore@dnd

* fix: remove node15 from ci

* feat: r.prop.satisfies

* chore@dnd

* feat: r.merge.with

* feat: juxt

* chore@small

* chore@small

* chore@small

* feat@typings r.flatten.object

* chore@small

* feat@dep upgrade all

* feat@dep upgrade jest.extended

* fix: r.always

* feat: r.partial.curry

Co-authored-by: Dejan Totev <dejan.totev@psinteractive.io>
Co-authored-by: Deyan Totev <deyan.totev.extern@seven.one>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants