R.prepend/R.append fns accept broader types
#699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, `R.prepend(4)` or `R.append(4)` would produce a function which
could only be applied to a `number[]`. However, you may well want to
append a `4` to an array whose elements can be `number`s or other
things, such as a `(string | number)[]`. This commit improves the types
to accept such arrays.
You may also have an array of a more specific type (such as `number[]`)
and wish to use `R.prepend`/`R.append` to expand the type. Because it's
usually a mistake, `append("d")(listOfNumbers)` will cause a type error;
however, explicitly calling `append("d")<string |
number>(listOfNumbers)` will give you a `(string | number)[]`.
Peeja
force-pushed
the
append-prepend-work-with-broader-types
branch
from
b847bac
to
f6b06b1
Compare
Not clear why this changed. Ideally, the test runner wouldn't care about the order of keys in an object type.
|
Thanks for this PR. I'd change few things before releasing:
|
|
Sounds good! I went with that sort of naming because I kept losing track of what was what otherwise, but please do adjust it as you see fit. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before,
R.prepend(4)orR.append(4)would produce a function which could only be applied to anumber[]. However, you may well want to append a4to an array whose elements can benumbers or other things, such as a(string | number)[]. This commit improves the types to accept such arrays.You may also have an array of a more specific type (such as
number[]) and wish to useR.prepend/R.appendto expand the type. Because it's usually a mistake,append("d")(listOfNumbers)will cause a type error; however, explicitly callingappend("d")<string | number>(listOfNumbers)will give you a(string | number)[].