Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeIndex has backward arguments #66

Closed
whitelizard opened this issue May 29, 2021 · 3 comments
Closed

removeIndex has backward arguments #66

whitelizard opened this issue May 29, 2021 · 3 comments

Comments

@whitelizard
Copy link

removeIndex seems to take a switched (wrong) order of the 2 arguments. And the tests seem to be wrong as well.

It should be removeIndex(index, list)

but it is removeIndex(list, index)

making it bad for composition.
@selfrefactor
Copy link
Owner

Thanks for filing this problem. I'll check it and get back to you.

@selfrefactor
Copy link
Owner

You are very correct. Typings are correct, but indeed the logic was wrong. The fix is already applied, but it will go live with the next release. I'll keep the issue open, so I can inform you once the new release is published.

@selfrefactor
Copy link
Owner

It should be released with 7.3.0. Let me know if the problem persist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@selfrefactor @whitelizard