Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #243

Merged
merged 3 commits into from
May 10, 2023
Merged

Fix deprecation warnings #243

merged 3 commits into from
May 10, 2023

Conversation

fiwswe
Copy link
Contributor

@fiwswe fiwswe commented Sep 7, 2022

Fixes #242

Works under Hogfather and Igor.

@Klap-in
Copy link
Collaborator

Klap-in commented Sep 7, 2022

This will break the older Greebo version, because _addCall was refactored in Hogfather.
For most plugins I would merge it already, but the Wrap plugin is one of the most used plugins. So I expect therefore relative more not yet updated installations are using it.
@selfthinker do you prefer longer backward compatibility, more than two releases?

@fiwswe
Copy link
Contributor Author

fiwswe commented Sep 7, 2022

I don't have any idea which versions are in actual use. But my 2¢ are: Hogfather is still important, while everything gets fixed and updated for Igor and PHP 8. Greebo not so much.

Looking at it from a different perspective: Hogfather was released more than 2 years ago. Dropping support for older systems should be acceptable.

But if required we could adjust the fix to differentiate between DW versions. Ugly and it opens a huge can of worms IMHO.

Plugin and Theme metadata and distribution lacks a mechanism to define DW compatibility. Or a mechanism to offer different versions for different DW versions. So when the DW API changes, there tend to be issues. Not sure if adding such a mechanism would be worthwhile. Something like that has the potential to add a lot of complexity for something not very important.

@splitbrain
Copy link
Contributor

I would agree Hogfather compatibility is enough. People who do not upgrade their wiki usually do not upgrade their plugins either ;-)

@selfthinker can we get this merged?

@Klap-in Klap-in merged commit 9a2e341 into selfthinker:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doku_Handler::_addCall() is deprecated.
3 participants