Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gaff.itp gaff2.itp #21

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

xiki-tempula
Copy link
Contributor

I have added the atomic number to the two itp. This fixed the #20.

@selimsami
Copy link
Owner

From a quick look, in gaff.itp it looks like the LJ parameters have changed. (f.e. atom type: ca)

@selimsami selimsami mentioned this pull request Nov 15, 2021
@xiki-tempula
Copy link
Contributor Author

I think this is probably because I'm using a newer version of the gaff (Version 1.81, May 2017), which is the latest version from ambertools. I wonder where did you obtain this gaff.itp?

@selimsami
Copy link
Owner

Can't really remember unfortunately. But it's best to use the most up-to-date version I assume.

I see that you obtained them with parmed, but do you have a reference/citation for these parameters? Just to avoid similar problems in the future.

@selimsami selimsami merged commit e51178f into selimsami:master Nov 19, 2021
@xiki-tempula
Copy link
Contributor Author

So parmed is a conversion package that parses the amber topology file and is part of the ambertools (so I don't need to write a script to read amber topology). Citation: https://dx.doi.org/10.1007/s10822-016-9977-1
So I install the amber tools with conda.
Then I use parmed to read the corresponding gaff.dat and gaff2.dat from the amber tools installation and write it to the itp files.
The exact code to generate the files is in the header of the itp file.

@selimsami
Copy link
Owner

Great, then I consider this issue resolved. Thanks for the new parameters!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants