Try to fix codecov #30
Closed
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 642a087.
|
@selimsami I have added a temporal fix to the codecov where I had qforce/.github/workflows/CI.yaml Line 52 in 0fa5057 changed to python -m pip install -e . I have no idea why it won't work without the -e but at least the code coverage is working fine now.
|
|
Hi @xiki-tempula , I made some changes to the CI implementation and managed to fix the requirement for pip install -e. Main problem was that tests directory was missing Have a look at the main branch and let me know if you have any suggestions. This PR is no longer needed. |
|
@selimsami Excellent, it seems to me that the changes are fine. Let's see if the build will succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.