peer_id isn't defined, shouldn't 'uid' be used instead

[callTx]

selkies-gstreamer/src/selkies_gstreamer/signalling_web.py

Line 321 in 007cc1e

room_id = self.peers[peer_id][2]

[callTx]

The peer_id in this line hasn't any definition. I was debugging the code and see came across this. So if I'm wrong you can close the issue.

[ehfd]

Oh, oh yes...
I think I understand what is the issue here.

[ehfd]

@callTx This is dead code, and the interpreter will never run that section.
But in case we do need to use the room functionality and thus run that code in the distant future, we will take note of it.
Thank you for pointing that out, however.

Code cleaning is eventually required.

[ehfd]

Relevant code: https://github.com/selkies-project/selkies-gstreamer/blob/master/src/selkies_gstreamer/signalling_web.py
Should be addressed with #39.

[callTx]

It appears to be working, but I'm not sure what effect it will have on the rest of the project. Em ter., 26 de abr. de 2022 às 08:21, Seungmin Kim ***@***.***> escreveu:

…

Oh, oh yes... I think I understand what is the issue here https://github.com/selkies-project/selkies-gstreamer/blob/master/src/selkies_gstreamer/signalling_web.py#L321 https://github.com/selkies-project/selkies-gstreamer/blob/master/src/selkies_gstreamer/signalling_web.py#L432 @danisla <https://github.com/danisla> Is this section actually executed? If so, it does look weird on why peer_id is over there. — Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIYW2VXBFOCODJ4B5UOVIYDVG7GUFANCNFSM5SIYAV6A> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[ehfd]

Deserves a rewrite of the signaling server.

[ehfd]

We will rewrite the signaling server in #39. But for now, this issue doesn't have direct implications for 1-to-1 WebRTC communication.