Use version 0.31 of python-xlib to fix regression #113
Conversation
Selkies-gstreamer process abruptly exits when using python-xlib >= 0.32 when non english characters are typed. This is a regression in python-xlib, so fixing the version to 0.31 solves temporalily the issue. There is a pending PR to python-xlib to fix the issue: python-xlib/python-xlib#242
|
Hi! I was pretty sure I knew your handle, and you're the one who made ubuntu-dind that I used with nvidia-dind! This is indeed a tricky problem to deal with. I'll think of the implications of pegging this version before merging or adding to this. |
|
Hahaha, it's such a small world! You created a project inspired by mine, and now I'm doing research inspired by your project 😂.
Yes, at first I thought it would be more difficult to do. |
|
I remember that something would break if I downgraded to 0.31. |
|
I will close this PR. I think I was too optimistic with the downgrade... It is a much more complex problem.
It starts correctly, but the keyboard still have issues: Case 1
In this particular case, the server crashes when I press "ñ" or other spanish characters. Case 2
No crashes Case 3:
No crashes. But the keyboard layout does not work properly. Some keys are translated, some not. Case 4:
Works fine, but also some characters are not translated correctly. For example, in Spanish layout, Ctrl + Shift + 0 resolves to the character "=", but instead, a ")" character appears. Some side notes This looks complex, and maybe other approach is needed, I am not sure. I've observed that other projects like Kasm NoVNC translates the host keyboard layout, so if I have my host keyboard layout as Would be good to research how other projects works (like neko, noVNC and Kasm noVNC), and somehow translate that to selkies :) |
|
Yes, a comparison between other interfaces are needed. We currently use an old version of the Guacamole keyboard. |
|
The last time there was some keyboard issue, it was related to pynput. Worth checking into the backend aspects if the Guacamole Keyboard behavior is inconsistent with guacd. |
|
Any updates? |
|
Currently discussed in #85 |
Hello, congrats on the project! I've been testing Selkies and I'm impressed how well it works. VNC is slow for remote desktops, and this actually demonstrates that it's possible to have a low-latency remote desktop experience using WebRTC :)
As a Spanish user, I've been troubled with some keyboard layout errors, which significantly impacts my experience. Basically, if you press a non english character, the selkies-gstreamer server crash with an exception. This issue appearead multiple times as I can see:
Initially, I suspected that the problem might be due to guacamole keyboard library being outdated, as discussed in these threads:
However, even after updating the guacamole keyboard library, the issue persisted. Further research led me to discover a regression in the xlib python library, specifically since version 0.32:
If you execute a
pip listcommand, the installed python-xlib version is 0.33. Fortunately, reverting the xlib version to 0.31 resolves the issue, and the server does not crash when a non english character is sent. What I did is basically pin the version 0.31 in thesetup.cfgconfig, which could temporarily solve the issue until a new version of python-xlib is released.There is a pending pull request (PR 242) that aims to address this problem in the xlib library, but it looks like the development is paused.