-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker commands to utilize coturn properly #134
Conversation
As the coturn is embedded into the selkies desktop, the host address is required for the client in order to utilize coturn server.
The realm argument is necessay for the coturn in order to support TURN capability
I acknowledge that both may be an issue. But, for the |
I tried with |
In that case, it would be possible to add that detail as a note and default to using automatic IP resolution. |
Sounds good. |
@PMohanJ Care to try making that change? I'll make the final edits tomorrow. |
Ok. I'll update that in a few minutes. |
@ehfd Any review on this? |
Give me a bit of time. |
Thank you. |
As the coturn is included in the desktop itself, when deploying the container in a VM rather than local env, the
TURN_HOST
variable is supposed to set to the host address of the machine, else the default valuelocalhost
is applied which in these scenarios fails the webrtc connection.Also when setting up the coturn server with the provided docker command it requires the realm flag/argument to set for the TURN capability to work https://github.com/coturn/coturn/blob/master/docker/coturn/turnserver.conf#L352.
This can be verified by doing an ICETEST.
Run the both containers and test them for ICE candidates at the given site and check for the
relay
candidates. The coturn without the realm flag doesn't returnrelay
ICE candidate.