Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various changes for usability #60

Merged
merged 25 commits into from
Oct 12, 2022
Merged

Various changes for usability #60

merged 25 commits into from
Oct 12, 2022

Conversation

ehfd
Copy link
Member

@ehfd ehfd commented Oct 4, 2022 •
edited
Loading

  • Remove tkinter dependency, not needed after all
  • Allow empty username for basic authentication if there is no $USER
  • Fix docs and base example image behavior
  • Ensure that libvpx is explicitly installed and supported
  • Change default from nvh264enc to x264enc so the project will start up by default without a NVIDIA GPU
  • Remove CPU thread restriction with vpx and x264, encoder will automatically determine number of threads (it was better, at least for me)
  • Fix Keyboard keys < and > do not work #6.

@ehfd ehfd changed the title Various small changes Various changes for usability Oct 6, 2022
@ehfd ehfd marked this pull request as draft October 6, 2022 15:41
@ehfd
Copy link
Member Author

ehfd commented Oct 7, 2022

image

#6 fixed with minimal side effects.

@ehfd ehfd mentioned this pull request Oct 7, 2022
Closed
@ehfd
Copy link
Member Author

ehfd commented Oct 7, 2022

Closes #6.

@ehfd ehfd mentioned this pull request Oct 7, 2022
Closed
16 tasks
@ehfd
Copy link
Member Author

ehfd commented Oct 7, 2022 •
edited
Loading

Note that we would want GStreamer 1.21.1 before a release when this is merged.

@ehfd ehfd marked this pull request as ready for review October 8, 2022 14:49
@ehfd
Copy link
Member Author

ehfd commented Oct 8, 2022

Ready for review @danisla

@ehfd
Copy link
Member Author

ehfd commented Oct 8, 2022

Fixes a lot of #40 but we'll put the rest in another PR.

@ehfd ehfd requested a review from danisla October 12, 2022 15:19
@ehfd
Copy link
Member Author

ehfd commented Oct 12, 2022

@danisla This can be merged. If I have something else I will raise another issue.

@danisla
Copy link
Member

danisla commented Oct 12, 2022

LGTM

@danisla danisla merged commit 48329d4 into selkies-project:master Oct 12, 2022
@ehfd ehfd deleted the edit-221004 branch October 13, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danisla danisla Awaiting requested review from danisla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyboard keys < and > do not work
2 participants
@ehfd @danisla