Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add post code support for Ireland #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add post code support for Ireland #3

wants to merge 2 commits into from

Conversation

kilgore5
Copy link

@kilgore5 kilgore5 commented Jan 7, 2019 •
edited
Loading

@kilgore5 kilgore5 assigned kilgore5 and unassigned kilgore5 Jan 7, 2019
@kilgore5
Copy link
Author

kilgore5 commented Jan 10, 2019 •
edited
Loading

Note, after some reading Eircodes don't seem to be used strictly and are not required by UPS (https://www.ups.com/worldshiphelp/WS19/ENU/AppHelp/Codes/Countries_Territories_Requiring_Postal_Codes.htm), so we should allow a properly formatted Eircode OR nil value.

see more discussion here: sellect/ups-ruby#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kilgore5