Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solarized-light in iTerm2 #155

Closed
benmezger opened this issue Apr 26, 2015 · 4 comments
Closed

Solarized-light in iTerm2 #155

benmezger opened this issue Apr 26, 2015 · 4 comments

Comments

@benmezger
Copy link

I am having difficulties to get Solarized-dark working in iTerm2.
My Terminal type is set to xterm-256color and I have solarized.iterm loaded as my iTerm2 theme.
In my .emacs I have:

; load solarized-theme
; https://github.com/sellout/emacs-color-theme-solarized
(add-to-list 'custom-theme-load-path "~/.emacs.d/solarized")
(load-theme 'solarized t)

This is the result -> https://i.imgur.com/tUwcuDQ.png

If I try M-x -> load-theme -> solarized-dark, I get the same result.

I tried setting my Terminal type to xterm-new, though it "works" I still see some solarized-light in a few parts, like so -> http://i.imgur.com/kHUe95m.png

Any idea of what to do?

Thanks

@sellout
Copy link
Owner

sellout commented Apr 26, 2015

The solarized-light and solarized-dark themes are deprecated (and I should probably get rid of them to eliminate confusion like this). Now there is only a single solarized theme that uses dark/light variants based on the frame’s background-mode (so you can mix dark and light frames in the same Emacs instance).

The hook I use to set this up (I use light for GUI frames and dark for term frames) is in the README: https://github.com/sellout/emacs-color-theme-solarized#all-versions. It could actually be a bit simpler for your case, but I don’t know any way to set default terminal parameters, so you need to make sure your background-mode is set to dark for each new terminal shrug. Let me know if that helps.

@benmezger
Copy link
Author

Awesome, I've seen you did a new push on the README.md, thanks for that.
I kinda fixed it by following the README.md, but only by adding:

(add-to-list 'custom-theme-load-path "~/.emacs.d/solarized")
(setq frame-background-mode 'dark)
(load-theme 'solarized-dark t)

This is what I got now -> https://i.imgur.com/nOF426q.png
As you can see in the powerline, it seems that some words are very difficult to read. Any idea what this could be? Perhaps I missed something?

@sellout
Copy link
Owner

sellout commented Apr 27, 2015

Powerline badness is a known issue: #115. I’ll look at that again.

I’m going to close this, but reopen if you feel it’s not resolved.

@sellout sellout closed this as completed Apr 27, 2015
@benmezger
Copy link
Author

Perfect.
This is what I added to my .emacs:

; load solarized-theme
; https://github.com/sellout/emacs-color-theme-solarized
(setq frame-background-mode 'dark)
(load-theme 'solarized-dark t)

Then;

; powerline
(setq sml/no-confirm-load-theme t)
(setq sml/theme 'respectful)
(sml/setup)

Apparently sml/theme solarized-dark doesn't work properly, instead, respectful seems to work quite fine.

As mentioned by @sellout, take a look at issue #115.
Cheers.

bradwright added a commit to bradwright/emacs-color-theme-solarized that referenced this issue Apr 30, 2015
Invoking the theme in Emacs 24+ is a matter of `(enable-theme
'solarized)`.

Additionally, these were marked as obsolete a long time ago, and as
mentioned in
sellout#155 it'd
be nice to get rid of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants