Unreadable colors in some mode and cannot compile

[favadi]

I really like this theme but in some mode, I can not read text.

• iswitchb
  
• hightlight bracket (paren mode)
  

And when I attempt to compile, I get the following error.

Compiling file /home/favadi/.emacs.d/themes/solarized/color-theme-solarized.el at Sat Feb 18 11:30:08 2012
Entering directory `/home/favadi/.emacs.d/themes/solarized/'
color-theme-solarized.el:13:1:Error: Wrong type argument: stringp, nil

Compiling file /home/favadi/.emacs.d/themes/solarized/solarized-dark-theme.el at Sat Feb 18 11:30:08 2012
solarized-dark-theme.el:1:1:Error: Symbol's value as variable is void: custom-theme-load-path

Compiling file /home/favadi/.emacs.d/themes/solarized/solarized-light-theme.el at Sat Feb 18 11:30:08 2012
solarized-light-theme.el:1:1:Error: Symbol's value as variable is void: custom-theme-load-path

[sellout]

It looks like you're running Emacs 23 or older, yes? If so, solarized-dark-theme.el and solarized-light-theme.el won't work. They are intended for Emacs 24 only. However, color-theme-solarized.el should work. How are you compiling the file? It sounds like neither load-file-name nor buffer-file-name is set.

As for the bad highlighting, could you try putting the point inside the highlighted area and typing M-x describe-face, then adding that info to the ticket? It looks like the iswitchb highlighting is caused by the same paren matching – but I'm a bit confused, because for me paren-mode only highlights the parens, not all the characters in between. (Is that something that's different pre-Emacs 24?)

Anyway, I submitted better paren-mode colors. Please let me know what you think.

[favadi]

Yes, I'm using emacs 23.

This is my config in init.el to load solarized.

;; Color theme
(add-to-list 'load-path "~/.emacs.d/themes/solarized/")
(require 'color-theme)
(require 'color-theme-solarized)
(eval-after-load "color-theme"
  '(progn
(color-theme-initialize)
(color-theme-solarized-dark)))
(setq color-theme-is-global t)

The function I use to compile.

(defun byte-recompile-home ()
  (interactive)
  (byte-recompile-directory "~/.emacs.d" 0))

For paren-mode, I use this setting to hightlight all characters in between.

;; Hightlight code beetween {}
(require 'paren)
(setq show-paren-style 'expression)
(show-paren-mode 1)

describe-face

Face: show-paren-match (sample) (customize this face)

Documentation:
Show Paren mode face used for a matching paren.

Defined in `paren.el'.

        Family: unspecified
       Foundry: unspecified
         Width: unspecified
        Height: unspecified
        Weight: unspecified
         Slant: unspecified
    Foreground: unspecified
    Background: steelblue3
     Underline: unspecified
      Overline: unspecified
Strike-through: unspecified
           Box: unspecified
       Inverse: unspecified
       Stipple: unspecified
          Font: unspecified
       Fontset: unspecified
       Inherit: unspecified

Your commit seem to fix the bad highlighting problem, but I still cannot compile color-theme-solarized.el.

[sellout]

The compilation issue should be fixed now. Sorry for the delay.

[Bohtvaroh]

I'm sorry but making matching brackets just bold is not enough for show-paren-mode - they are still almost indistinguishable. Can you somehow improve this, please? Some letter background highlighting would be nice.

[Bohtvaroh]

Oh, I see - that's hl-line-mode which makes them less visible...

[sellout]

I'd be happy for some suggestions to make show-paren-mode and hl-line-mode work together better, but I don't use either of them. In fact, I use parenface to make the parentheses stand out less ;)

[ioreshnikov]

@sellout The version of the vim theme, that I have containts:
exe "hi! MatchParen" .s:fmt_bold .s:fg_red .s:bg_base01
The background color is darker than background of the hl-line. As for the foreground, I'd leave it just bold.