Add faces for dired+ #193
Open
Add faces for dired+ #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work, thx. Missed that faces long time now |
sellout
requested changes
Feb 9, 2023
| @@ -582,6 +584,7 @@ the \"Gen RGB\" column in solarized-definitions.el to improve them further." | |||
| (helm-bookmark-man (,@fg-violet)) | |||
| (helm-bookmark-w3m (,@fg-yellow)) | |||
| (helm-bookmarks-su (,@fg-orange)) | |||
| (helm-buffer-directory (:inherit helm-ff-directory)) | |||
There was a problem hiding this comment.
I’d be happy to take the changes from here down, if you want to update the PR.
| @@ -165,7 +165,7 @@ the \"Gen RGB\" column in solarized-definitions.el to improve them further." | |||
| (italic (if solarized-italic 'italic 'unspecified))) | |||
| (cond ((eq 'high solarized-contrast) | |||
| (let ((orig-base3 base3)) | |||
| (rotatef base01 base00 base0 base1 base2 base3) | |||
| (cl-rotatef base01 base00 base0 base1 base2 base3) | |||
There was a problem hiding this comment.
Current version no longer uses rotatef.
| @@ -252,7 +252,7 @@ the \"Gen RGB\" column in solarized-definitions.el to improve them further." | |||
| (,@fg-base1 ,@bg-base02 ,@fmt-revbb :box nil)) | |||
| (mode-line-inactive ; StatusLineNC | |||
| (,@fg-base00 ,@bg-base02 ,@fmt-revbb :box nil)) | |||
| (region (,@fg-base01 ,@bg-base03 ,@fmt-revbb)) ; Visual | |||
| (region (:background base02 :foreground nil :inverse-video nil)) | |||
There was a problem hiding this comment.
This comes directly from the Vim theme, so I’m not likely to change it. But soon I’ll merge something like #191 which would make it easy to define variations like this locally (while still being able to refer to base02, etc.).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added faces for dired+.
Could you merge this patch?