Merge pull request #13 from selsa-inube/cmarin/ids1649/adjustment-to-…

…use-semantic-html Update Navigation to Use HTML `<nav>` Tag for Semantics
selsa-inube · Jun 4, 2024 · 14bea4b · 14bea4b
2 parents 5868394 + 56d5851
commit 14bea4b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/src/Nav/index.tsx b/src/Nav/index.tsx
@@ -22,8 +22,8 @@ import { Icon } from "@inubekit/icon";
 
 interface INav {
   navigation: INavNavigation;
-  logoutPath: string;
-  logoutTitle: string;
+  logoutPath?: string;
+  logoutTitle?: string;
   collapse?: boolean;
 }
 
@@ -204,13 +204,17 @@ const Nav = (props: INav) => {
               logoutTitle={logoutTitle}
             />
           )}
-          <SeparatorLine />
-          <NavLink
-            id="logout"
-            label={logoutTitle}
-            icon={<MdLogout />}
-            path={logoutPath}
-          />
+          {logoutTitle && logoutPath && (
+            <>
+              <SeparatorLine />
+              <NavLink
+                id="logout"
+                label={logoutTitle}
+                icon={<MdLogout />}
+                path={logoutPath}
+              />
+            </>
+          )}
         </Stack>
         <StyledFooter>
           <Stack justifyContent="center">

diff --git a/src/Nav/styles.js b/src/Nav/styles.js
@@ -33,7 +33,7 @@ const StyledFooter = styled.footer`
   width: 100%;
 `;
 
-const StyledNav = styled.div`
+const StyledNav = styled.nav`
   width: 248px;
   box-sizing: border-box;
   background-color: ${({ theme }) =>