Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust and export interfaces #6

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

JanuarAsprilla
Copy link
Contributor

The names of the interfaces used by the <Nav /> component were refactored, as well as how they are exported.

@wfercanas wfercanas added the minor Increment the minor version when merged label Mar 26, 2024
src/Nav/index.tsx Outdated Show resolved Hide resolved
src/Nav/index.tsx Outdated Show resolved Hide resolved
src/Nav/index.tsx Outdated Show resolved Hide resolved
src/Nav/index.tsx Outdated Show resolved Hide resolved
src/Nav/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@wfercanas wfercanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In vite.config.ts we have to use "react-icons/md", without the md the build size is 11kb, while with the md the build size is 7kb.

@wfercanas wfercanas merged commit efe5c61 into main Apr 1, 2024
@wfercanas wfercanas deleted the ja/1413/Adjust_and_export_interfaces branch April 1, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants