Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forceSsl exceptions #13

Merged
merged 2 commits into from
Oct 25, 2018
Merged

Fix forceSsl exceptions #13

merged 2 commits into from
Oct 25, 2018

Conversation

chrisrowe
Copy link
Contributor

@chrisrowe chrisrowe commented Oct 23, 2018

This ensures Patrol starts with a baseUrl containing the schema (and includes a port if used) before trimming/replacing http: and avoids it throwing a FILTER_VALIDATE_URL exception. I also added the available override setting to the readme.

This returns the schema (http/s) along with the request URL
@chrisrowe
Copy link
Contributor Author

I also remembered after digging through Yii's Request.php that both serverName and hostInfo are susceptible to Host spoofing by passing a header. Is this something primaryDomain is designed for, to prevent cache poisoning attacks?

@selvinortiz selvinortiz merged commit 3bc478a into verbb:master Oct 25, 2018
@selvinortiz
Copy link
Contributor

@chrisrowe Thank you!

I've been lagging behind on Patrol maintenance, your help is much appreciated.

Primary domain is used in routing but for a slightly different purpose than SSL alone.
It let's you redirect to a specific domain if your site/app can be accessed via different domains.

@chrisrowe
Copy link
Contributor Author

chrisrowe commented Oct 30, 2018

@selvinortiz Thanks, any idea when you'll be cutting a new release for this?

@selvinortiz
Copy link
Contributor

@chrisrowe Sorry about the delay, Chris. I'll do my best to cut a new release before the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants