You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you very much for spotting this bug in my code. Without the help and support of our community, we would not be able to find and test all possible code. I identified the problem.
The function for calculating the total_effects had some faulty logic.
specifically, the function is as follows:
to calculate total effects, we simply need to multiply the path coefficients matrix with iteself and add the product. This continues until the product of the path coef matrix is equal to zero (no more indirect effects).
In my logic I had used a while() statement which said to continue calculating the product of the path coef matrix and adding it up until the paths matrix sums to a non-positive. This makes sense because the product of a number with itself cannot be negative.
However I did not consider that the initial starting point could sum to a non-neg. Thus, the function was never executing.
Nevertheless, you have brought this glitch to our attention and I can now deploy the bug-fix in our next version. In the meantime, you can download the bugfix version (temp) using:
#308)
* changes to indexing in get_sm_nodes() to fix a bug that arises from using a single letter construct name. Issue #305
* Attend issue #309 regarding bug in total_effects() function
* Addresses issue #289 - bug when calculating fSquared on HOC models
* Addreswses issue #310
* refactor to use smMatrix helper function
* Remove browser() from code
* final changes to bugfixes
Co-authored-by: Nicholas Danks <nicholasdanks@Nicholass-MacBook-Pro-2.local>
Co-authored-by: Nicholas Danks <you@example.com>
Co-authored-by: Soumya Ray <soumya.ray@gmail.com>
Thank you very much for spotting this bug in my code. Without the help and support of our community, we would not be able to find and test all possible code. I identified the problem.
The function for calculating the total_effects had some faulty logic.
specifically, the function is as follows:
to calculate total effects, we simply need to multiply the path coefficients matrix with iteself and add the product. This continues until the product of the path coef matrix is equal to zero (no more indirect effects).
In my logic I had used a while() statement which said to continue calculating the product of the path coef matrix and adding it up until the paths matrix sums to a non-positive. This makes sense because the product of a number with itself cannot be negative.
However I did not consider that the initial starting point could sum to a non-neg. Thus, the function was never executing.
My fix is as followS:
Nevertheless, you have brought this glitch to our attention and I can now deploy the bug-fix in our next version. In the meantime, you can download the bugfix version (temp) using:
The text was updated successfully, but these errors were encountered: