Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a skipTag option to turn off git tagging #128

Merged
merged 1 commit into from Aug 5, 2020

Conversation

JoA-MoS
Copy link
Collaborator

@JoA-MoS JoA-MoS commented Aug 5, 2020

Adds the ability to skip creating the git tag

This will support a workflow in situations where a the version is needed prior to creating a release. Common languages that require this are Java, C# (.net), C++.

Another scenario is when publishing docker images that a version number needs to be present inside the docker image.

This relates to the following PR's/Issues:

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          839       839           
  Branches       220       220           
=========================================
  Hits           839       839           
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ec237...4e3c7d6. Read the comment docs.

@JoA-MoS
Copy link
Collaborator Author

JoA-MoS commented Aug 5, 2020

FYI: @JeffBeltran, @simlu

@JoA-MoS JoA-MoS merged commit c97c379 into master Aug 5, 2020
@JoA-MoS
Copy link
Collaborator Author

JoA-MoS commented Aug 5, 2020

🎉 This PR is included in version 18.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JoA-MoS JoA-MoS deleted the adds-skip-tagging-option branch July 20, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant