fix(woodpecker): update woodpecker env vars

[qwerty287]

Hi!
Woodpecker updated some env var names (see https://woodpecker-ci.org/docs/next/migrations#100). This PR updates them to the latest ones.

[travi]

i'm not a user of woodpecker, so i could use some help understanding the impact of this change. are the old values no longer available on new versions of woodpecker servers? could some folks still be using older versions of a woodpecker server where these new values are not available (meaning this would be a breaking change)? any other impacts that we should communicate to consumers?

[qwerty287]

i'm not a user of woodpecker, so i could use some help understanding the impact of this change. are the old values no longer available on new versions of woodpecker servers?

Not yet, so all currently released versions support both. They're deprecated and will be removed in next versions.

could some folks still be using older versions of a woodpecker server where these new values are not available

This is also unlikely because they're available for some time already and all supported versions support these new env vars. If your woodpecker server is on an unsupported old version this could be possible, but otherwise not.

[qwerty287]

Hey @travi, can we go on with this?

[qwerty287]

Hi @travi, the situation has changed. Woodpecker released a new version that must use these new env vars (all other versions still using the old ones are not supported so they shouldn't be used anymore).

I'd like to get this done. Merge this in the next days, or I'll close it, but then this package won't work with woodpecker anymore. I don't understand why reviewing a PR changing just 10 lines takes over 3 weeks to get merged. (And I can see in you GitHub activity that you're not completely inactive.)

[qwerty287]

@travi I'm closing this now.
It's really sad that this project seems to be abandoned and nobody cares about it.

[travi]

Merge this in the next days, or I'll close it, but then this package won't work with woodpecker anymore

what positive outcome does this bring? by closing your PR, you have no chance of it being merged. i'm not going to apologize for the timeline. i would normally be more apologetic for not communicating my plan more openly, but behavior like this makes me far less concerned about your goals.

I don't understand why reviewing a PR changing just 10 lines takes over 3 weeks to get merged.

this is a breaking change. even if it is unlikely to break many folks in reality, it is still a breaking change and would be released as a major version. semantic-release is the primary consumer of this package and that type of breaking change is also a breaking change for semantic-release, so would not be merged into semantic-release until we are ready to release a new major there. during this time, i've been coordinating other pieces that would go into a major release of semantic-release, so i could make the timing of merging this have the smoothest upgrade path possible.

i had hoped to get a beta release of the next major started this last friday, but didnt manage to get to it. part of that plan was to get this merged and released as part of that.

I'd like to get this done

so would i, but the state of OSS is that accepting contributions and considering impacts to our consumers takes time and effort.

And I can see in you GitHub activity that you're not completely inactive

yes, i do have other priorities than yours

if you want this included in the next major, feel free to re-open, but you need to be patient. if that major version is released without this change, releasing this change will likely be delayed significantly more

[qwerty287]

yes, i do have other priorities than yours

That's fine, but this was open a month now.

if you want this included in the next major, feel free to re-open, but you need to be patient. if that major version is released without this change, releasing this change will likely be delayed significantly more

I reopened, but I don't really see it's a breaking change. You shouldn't use unsupported versions of a software, so it will be broken on newer woodpecker versions instead, and merging this shouldn't break anyone that uses a supported version.

[travi]

@qwerty287 i'm ready to get this merged in support of semantic-release/semantic-release#3111, but it looks like there are test failures.

could you look into resolving those failures?

[qwerty287]

@travi Fixed with e1a85e9.

[github-actions]

🎉 This PR is included in version 11.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[travi]

if you are using env-ci through semantic-release, this is now available there as a beta release: https://github.com/semantic-release/semantic-release/releases/tag/v23.0.0-beta.3