Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose environment into a command template #117

Closed
wants to merge 5 commits into from
Closed

Expose environment into a command template #117

wants to merge 5 commits into from

Conversation

konradekk
Copy link

hi! nicely done this plugin here of yours!

i’d like to have environment variables passed into the template—i thought i prepare a pr for you to speed up things (discussions, merger, deployment etc.)… i’d happily give more details or amend the pr if needed.

cheers!

@konradekk konradekk changed the title feat: expose env into command template Expose environment into a command template Oct 31, 2020
@hasezoey
Copy link

sorry to ask this, but any news from an maintainer on this PR?

@konradekk
Copy link
Author

He apparently shows up from time to time, I guess. But it’s more like once a year or so than every two weeks… So here, it seems we still have roughly ca. half a year. ;)

Be patient or… just fork that! (I did not tested that—so feel free to tell how it went etc.! Thanks in advance for the feedback!)

@hasezoey
Copy link

I did not tested that—so feel free to tell how it went etc.! Thanks in advance for the feedback!

for my use-case i just ended up using an command that directly takes an environment variable from the environment (for completing it was semantic-release-rust)

@konradekk
Copy link
Author

konradekk commented Jun 23, 2021

Neat! I don’t want to invest time in that if it won’t be used—and it seems it won’t as there’s quite a big lag regarding any kind of interaction with the maintainer(s)… 😅

@konradekk
Copy link
Author

Is this anyhow needed for anybody? 🤔

@hasezoey
Copy link

Is this anyhow needed for anybody? thinking

i am currently not "requiring" this, but this would probably be useful, because currently you either had the wanted program to have environment variables, or required to wrap the command in a script

@konradekk konradekk closed this Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants