chore(package): update xo to version 0.24.0

index.js

@@ -30,6 +30,7 @@ async function publish(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   return publishGitHub(pluginConfig, context);
 }
 
@@ -38,6 +39,7 @@ async function success(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   await successGitHub(pluginConfig, context);
 }
 
@@ -46,6 +48,7 @@ async function fail(pluginConfig, context) {
     await verifyGitHub(pluginConfig, context);
     verified = true;
   }
+
   await failGitHub(pluginConfig, context);
 }
 

lib/definitions/errors.js

@@ -1,9 +1,8 @@
-const url = require('url');
 const {inspect} = require('util');
 const {isString} = require('lodash');
 const pkg = require('../../package.json');
 
-const homepage = url.format({...url.parse(pkg.homepage), ...{hash: null}});
+const [homepage] = pkg.homepage.split('#');
 const stringify = obj => (isString(obj) ? obj : inspect(obj, {breakLength: Infinity, depth: 2, maxArrayLength: 5}));
 const linkify = file => `${homepage}/blob/master/${file}`;
 

lib/get-client.js

@@ -1,4 +1,4 @@
-const url = require('url');
+const {URL} = require('url');
 const {memoize, get} = require('lodash');
 const Octokit = require('@octokit/rest');
 const pRetry = require('p-retry');
@@ -35,7 +35,7 @@ module.exports = ({githubToken, githubUrl, githubApiPathPrefix, proxy}) => {
     baseUrl,
     request: {
       agent: proxy
-        ? baseUrl && url.parse(baseUrl).protocol.replace(':', '') === 'http'
+        ? baseUrl && new URL(baseUrl).protocol.replace(':', '') === 'http'
           ? new HttpProxyAgent(proxy)
           : new HttpsProxyAgent(proxy)
         : undefined,
@@ -54,6 +54,7 @@ module.exports = ({githubToken, githubUrl, githubApiPathPrefix, proxy}) => {
         if (SKIP_RETRY_CODES.includes(error.status)) {
           throw new pRetry.AbortError(error);
         }
+
         throw error;
       }
     }, RETRY_CONF);

lib/get-search-queries.js

@@ -7,6 +7,7 @@ module.exports = (base, commits, separator = '+') => {
     } else {
       searches.push(`${base}${separator}${commit}`);
     }
+
     return searches;
   }, []);
 };

lib/glob-assets.js

@@ -42,6 +42,7 @@ module.exports = async ({cwd}, assets) =>
                 // - other properties of the original asset definition
                 return globbed.map(file => ({...asset, path: file, name: basename(file)}));
               }
+
               // If asset is an Object, output an Object definition with:
               // - `path` of the matched file if there is one, or the original `path` definition (will be considered as a missing file)
               // - other properties of the original asset definition

lib/publish.js

@@ -45,6 +45,7 @@ module.exports = async (pluginConfig, context) => {
           logger.error('The asset %s cannot be read, and will be ignored.', filePath);
           return;
         }
+
         if (!file || !file.isFile()) {
           logger.error('The asset %s is not a file, and will be ignored.', filePath);
           return;

package.json

@@ -48,7 +48,7 @@
     "server-destroy": "^1.0.1",
     "sinon": "^7.1.1",
     "tempy": "^0.2.1",
-    "xo": "^0.23.0"
+    "xo": "^0.24.0"
   },
   "engines": {
     "node": ">=8.3"

test/get-client.test.js

@@ -170,8 +170,6 @@ test('Use different throttler for read and write endpoints', async t => {
 
 test('Use the same throttler when retrying', async t => {
   const coreRate = 200;
-
-  // eslint-disable-next-line require-await
   const request = stub().callsFake(async () => {
     const err = new Error();
     err.time = Date.now();