Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get rid of import assertion #708

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Apr 29, 2024

Neither import assertions nor the with keyword is supported across our supported versions.

Instead of going for a breaking change and raise our Node dependency I suggest we apply the same logic as in the GitHub plugin.

Resolves #704

@fgreinacher fgreinacher changed the base branch from master to ci/node-22 April 29, 2024 13:51
@fgreinacher fgreinacher changed the base branch from ci/node-22 to master April 29, 2024 13:52
@fgreinacher fgreinacher requested a review from travi April 29, 2024 13:53
@fgreinacher fgreinacher marked this pull request as ready for review April 29, 2024 13:53
@travi
Copy link
Member

travi commented Apr 29, 2024

Neither import assertions nor the with keyword is supported across our supported versions.

Thanks for confirming that. Absolutely agree given that info 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module causes failures in node version 22
2 participants